gitea
/
go-sdk
28
28
Fork 33
Code Issues 16 Pull Requests 3 Releases 15 Wiki Activity
Labels Milestones

Move all structs from code.gitea.io/gitea/modules/structs to local to resolve the dependencies problem #188

Merged
lunny merged 2 commits from lunny/go-sdk:lunny/remove_dependency_gitea into master 3 years ago
Conversation 0 Commits 2 Files Changed 36
lunny commented 3 years ago
Owner

fix #177

This PR will remove the dependency on code.gitea.io/gitea/modules/structs and copy all necessary structs from that package.

After this change, we have to consider how to resolve the compatible between go-sdk and gitea.

I propose to create branches/tags on go-sdk to follow gitea’s branches/tags. That means when gitea create a new branch i.e. release/v1.10. go-sdk should also create a branch release/v1.10 to follow gitea’s change. Then you could use different branches to operate different version Gitea.

fix #177 This PR will remove the dependency on `code.gitea.io/gitea/modules/structs` and copy all necessary structs from that package. After this change, we have to consider how to resolve the compatible between go-sdk and gitea. I propose to create branches/tags on go-sdk to follow gitea’s branches/tags. That means when gitea create a new branch i.e. `release/v1.10`. go-sdk should also create a branch `release/v1.10` to follow gitea’s change. Then you could use different branches to operate different version Gitea.
👍 1
lunny added the
kind/enhancement
 label 3 years ago
jolheiser approved these changes 3 years ago
Dismissed
zeripath approved these changes 3 years ago
Dismissed
lunny closed this pull request 3 years ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as e41e9ea72c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
has/backport has/pull in progress invalid kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/lint kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation kind/ui need/backport priority/critical priority/low priority/maybe priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/needs-feedback status/needs-reviews status/wip upstream/gitea
No Label has/backport has/pull in progress invalid kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/lint kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation kind/ui need/backport priority/critical priority/low priority/maybe priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/needs-feedback status/needs-reviews status/wip upstream/gitea
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#188
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'lunny/go-sdk:lunny/remove_dependency_gitea'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes