Add Pagination Options for List Requests #205

Merged
lunny merged 36 commits from spawn2kill/go-sdk:pagination into master 3 years ago

Same as #203

Same as #203
Collaborator

@spawn2kill: https://github.com/go-gitea/gitea/pull/9452 adds support on Gitea’s API to pagination in most of the requests

> @spawn2kill: https://github.com/go-gitea/gitea/pull/9452 adds support on Gitea’s API to pagination in most of the requests
6543 added the
kind/feature
label 3 years ago
6543 added this to the v0.12.0 milestone 3 years ago
6543 added the
kind/breaking
label 3 years ago
Owner

Please resolve the conflicts

Please resolve the conflicts
Collaborator

@lunny only worth it after https://github.com/go-gitea/gitea/pull/9452 got merged ...

but it looks like nobody has time to review :/

@lunny only worth it after https://github.com/go-gitea/gitea/pull/9452 got merged ... but it looks like nobody has time to review :/
6543 added the
status/blocked
label 3 years ago
Collaborator

@spawn2kill can you adjust this PR ? (now as your PR is merged upstream)

and fix conflict ;)

@spawn2kill can you adjust this PR ? (now as your PR is merged upstream) and fix conflict ;)
Poster

I will as soon as I get some free time :)

I will as soon as I get some free time :)
Collaborator

dont stress yourself ... since this will be a breaking change. And v0.11.0 is released first

dont stress yourself ... since this will be a breaking change. And v0.11.0 is released first
Collaborator

By the way you should add a version check like this one:

7892df812a

By the way you should add a version check like this one: https://gitea.com/gitea/go-sdk/commit/7892df812a73e4b0cdb694e06790808d75719717
6543 added a new dependency 3 years ago
Poster

And once again, an huge PR 😂

And once again, an huge PR :joy:
6543 requested changes 3 years ago
Dismissed
6543 left a comment
Collaborator

this need a litle b8t more work

this need a litle b8t more work
6543 reviewed 3 years ago
Dismissed
6543 commented 3 years ago
Collaborator

why differ from models/list_options.go struct ?

why differ from `models/list_options.go` struct ?
Poster

fixed

fixed
6543 marked this conversation as resolved
Collaborator
  • gitea/issue_milestone.go -> #244
  • all other ListOptions are named in this maner: ListrecourceOption
  • I would like to leave all Options optional so dont move required options in them
* `gitea/issue_milestone.go` -> #244 * all other ListOptions are named in this maner: `ListrecourceOption` * I would like to leave all Options optional so dont move required options in them
6543 reviewed 3 years ago
Dismissed
6543 commented 3 years ago
Collaborator

why remove the copyright header?

why remove the copyright header?
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
PerPage int
}
func (o ListOptions) getURLQueryEncoded() string {
6543 commented 3 years ago
Collaborator

useles function you always can use getURLQuery().Encode() instead

useles function you always can use `getURLQuery().Encode()` instead
6543 reviewed 3 years ago
Dismissed
}
}
func (o ListOptions) getPerPage() int {
6543 commented 3 years ago
Collaborator

i would ceep it simple and would remove getPerPage()

instead use:

opts.setDefaults()
someVar := opts.PageSize

it makes it clear what the code does

i would ceep it simple and would remove `getPerPage()` instead use: ``` opts.setDefaults() someVar := opts.PageSize ``` it makes it clear what the code does
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListOrgHooksOptions options for listing organization's hooks
type ListOrgHooksOptions struct {
6543 commented 3 years ago
Collaborator

why not use ListHooksOptions for ListOrgHooks() and ListRepoHooks() ?

why not use ListHooksOptions for ListOrgHooks() and ListRepoHooks() ?
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
link.RawQuery = options.QueryEncode()
return issues, c.getParsedResponse("GET", link.String(), jsonHeader, nil, &issues)
}
6543 commented 3 years ago
Collaborator

dont delete if len(opt.State) > 0 { ...

dont delete `if len(opt.State) > 0 { ...`
Poster

it was actually duplicated

it was actually duplicated
6543 commented 3 years ago
Collaborator

o your right ... in this case it sure ok :)

o your right ... in this case it sure ok :)
6543 commented 3 years ago
Collaborator

I already have this fix in #243 :D

I already have this fix in #243 :D
6543 commented 3 years ago
Collaborator

this could cause you or me a mergeconflict :)

this could cause you or me a mergeconflict :)
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
options.setDefaults()
comments := make([]*Comment, 0, options.PageSize)
if err := c.CheckServerVersionConstraint(">=1.12.0"); err != nil {
return comments, err
6543 commented 3 years ago
Collaborator

why make this function unusable for gitea instances below 1.12.0 ?!?

why make this function unusable for gitea instances below 1.12.0 ?!?
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
func (o ListOptions) getURLQuery() url.Values {
o.setDefaults()
6543 commented 3 years ago
Collaborator

i would not implicit setDefaults as you have it explicit on each function anyway (give more indifidual control to each api call function)

i would not implicit setDefaults as you have it explicit on each function anyway (give more indifidual control to each api call function)
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
o.Page = 1
}
if o.PageSize < 0 || o.PageSize > 50 {
6543 commented 3 years ago
Collaborator

can you add a varialbe on the beginging of gitea/list_options.go witch contain this vaule (50)?

can you add a varialbe on the beginging of `gitea/list_options.go` witch contain this vaule (50)?
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListMyOrgsOptions options for listing current user's organizations
type ListMyOrgsOptions struct {
6543 commented 3 years ago
Collaborator

can you let ListMyOrgs() and ListUserOrgs() use ListOrgsOptions ?

can you let `ListMyOrgs()` and `ListUserOrgs()` use `ListOrgsOptions` ?
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListOrgTeamsOptions options for listing organization's teams
type ListOrgTeamsOptions struct {
6543 commented 3 years ago
Collaborator

same here -> ListTeamsOptions for ListOrgTeams() & ListMyTeams()

same here -> ListTeamsOptions for ListOrgTeams() & ListMyTeams()
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
// ListPullRequestsOptions options for listing pull requests
type ListPullRequestsOptions struct {
Page int `json:"page"`
ListOptions `json:"-"`
6543 commented 3 years ago
Collaborator

just use ListOptions

just use `ListOptions`
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListMyReposOptions options for listing current's user repositories
type ListMyReposOptions struct {
6543 commented 3 years ago
Collaborator

ListReposOptions ... for ListMyRepos() ListUserRepos() ListOrgReposOptions()

ListReposOptions ... for ListMyRepos() ListUserRepos() ListOrgReposOptions()
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
func (c *Client) ListMyFollowing(page int) ([]*User, error) {
users := make([]*User, 0, 10)
return users, c.getParsedResponse("GET", fmt.Sprintf("/user/following?page=%d", page), nil, nil, &users)
func (c *Client) ListMyFollowing(options ListMyFollowingOptions) ([]*User, error) {
6543 commented 3 years ago
Collaborator

use ListFollowingOptions for ListMyFollowing() too

use ListFollowingOptions for ListMyFollowing() too
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
import "fmt"
// ListMyFollowersOptions options for listing current's user's followers
type ListMyFollowersOptions struct {
6543 commented 3 years ago
Collaborator

use ListFollowersOptions for ListMyFollowers() too

use ListFollowersOptions for ListMyFollowers() too
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListMyGPGKeys list all the GPG keys of current user
func (c *Client) ListMyGPGKeys() ([]*GPGKey, error) {
6543 commented 3 years ago
Collaborator

use ListMyGPGKeysOption for ListMyGPGKeys() too

use ListMyGPGKeysOption for ListMyGPGKeys() too
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListGPGKeys options for listing a user's GPGKeys
type ListGPGKeys struct {
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
func (c *Client) ListMyPublicKeys() ([]*PublicKey, error) {
keys := make([]*PublicKey, 0, 10)
return keys, c.getParsedResponse("GET", "/user/keys", nil, nil, &keys)
func (c *Client) ListMyPublicKeys(options ListMyPublicKeysOptions) ([]*PublicKey, error) {
6543 commented 3 years ago
Collaborator

use ListPublicKeysOptions for ListMyPublicKeys() too

use ListPublicKeysOptions for ListMyPublicKeys() too
Poster

fixed

fixed
6543 marked this conversation as resolved
6543 requested changes 3 years ago
Dismissed
6543 left a comment
Collaborator

need still some work

need still some work
6543 reviewed 3 years ago
Dismissed
}
// ListRepoLabelsOptions options for listing repository's labels
type ListRepoLabelsOptions struct {
6543 commented 3 years ago
Collaborator

ListLabelsOptions for ListRepoLabels() and GetIssueLabels()

ListLabelsOptions for ListRepoLabels() and GetIssueLabels()
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
6543 reviewed 3 years ago
Dismissed
6543 reviewed 3 years ago
Dismissed
// ListRepoTopics list all repository's topics
func (c *Client) ListRepoTopics(user, repo string, opt ListRepoTopics) (*TopicsList, error) {
var list TopicsList
6543 commented 3 years ago
Collaborator

opt.setDefaults()

opt.setDefaults()
6543 marked this conversation as resolved
6543 requested changes 3 years ago
Dismissed
6543 left a comment
Collaborator

still some nits

still some nits
6543 approved these changes 3 years ago
Dismissed
6543 left a comment
Collaborator

🎉

:tada:
6543 approved these changes 3 years ago
Dismissed
6543 removed the
status/blocked
label 3 years ago
Collaborator

@spawn2kill #254 is merged, so now you can also add pagination to it in this PR

@spawn2kill #254 is merged, so now you can also add pagination to it in this PR
Collaborator

pleace resolve conflict

  • gitea/issue_comment.go
  • gitea/user_app.go
pleace resolve conflict * `gitea/issue_comment.go` * `gitea/user_app.go`
6543 reviewed 3 years ago
Dismissed
// ListRepoIssueComments list comments for a given repo.
func (c *Client) ListRepoIssueComments(owner, repo string) ([]*Comment, error) {
comments := make([]*Comment, 0, 10)
6543 commented 3 years ago
Collaborator

can you use ListIssueCommentsOptions for ListRepoIssueComments too?

can you use **ListIssueCommentsOptions** for ListRepoIssueComments too?
6543 marked this conversation as resolved
6543 requested changes 3 years ago
Dismissed
6543 left a comment
Collaborator

found something

found something
Collaborator

can you pleace resolve the conflichts ... yes they are back again :O

can you pleace resolve the conflichts ... yes they are back again :O
6543 reviewed 3 years ago
Dismissed
test-instance:
rm -r ${WORK_DIR}/test 2> /dev/null; \
mkdir -p ${WORK_DIR}/test/conf/ ${WORK_DIR}/test/data/
wget "https://dl.gitea.io/gitea/master/gitea-master-darwin-10.6-amd64" -O ${WORK_DIR}/test/gitea-master; \
6543 commented 3 years ago
Collaborator

better use git add -p ?

better use `git add -p` ?
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
func (c *Client) ListMyRepos() ([]*Repository, error) {
repos := make([]*Repository, 0, 10)
return repos, c.getParsedResponse("GET", "/user/repos", nil, nil, &repos)
func (c *Client) ListMyRepos(opt *ListReposOptions) ([]*Repository, error) {
6543 commented 3 years ago
Collaborator

opt *ListReposOptions -> opt ListReposOptions

`opt *ListReposOptions` -> `opt ListReposOptions`
6543 marked this conversation as resolved
6543 added a new dependency 3 years ago
6543 reviewed 3 years ago
Dismissed
jsonHeader, bytes.NewReader(body), status)
status := new(Status)
return status, c.getParsedResponse("POST", fmt.Sprintf("/repos/%s/%s/statuses/%s", owner, repo, sha), jsonHeader, bytes.NewReader(body), status)
}
6543 commented 3 years ago
Collaborator

dont breake things if necesar!!

rename ListStatusesOptions back to ListStatusesOption

dont breake things if necesar!! rename `ListStatusesOptions` back to `ListStatusesOption`
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
}
// ListAccessTokens options for listing a users's access tokens
type ListAccessTokens struct {
6543 commented 3 years ago
Collaborator

rename to ListAccessTokensOptions

rename to ListAccessTokensOptions
6543 marked this conversation as resolved
6543 reviewed 3 years ago
Dismissed
6543 approved these changes 3 years ago
Dismissed
6543 left a comment
Collaborator

lgtm

lgtm
zeripath reviewed 3 years ago
Dismissed
zeripath left a comment
Owner

So this is major breaking change for the SDK almost every signature is changed.

So this is major breaking change for the SDK almost every signature is changed.
zeripath approved these changes 3 years ago
Dismissed
lunny referenced this issue from a commit 3 years ago
added pagination options for listing requests (#205) fix golint issue small improvements ListMyRepos now receives a value instead of a pointer reverted makefile changes added sleep in order to increase CI stability resolved conflicts Use RepositoryMeta struct on Issues (#267) Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/267 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: techknowlogick <techknowlogick@gitea.io> extend SearchUsers (#248) Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: spawn2kill <spawn2kill@noreply.gitea.io> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/248 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Implement Repo Transfer (#264) fix test check version add TestRepoTransfer add TransferRepo Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/264 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Add notifications (#226) Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: spawn2kill <spawn2kill@noreply.gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/226 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Use StateType (#265) use StateType Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/265 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> opt setDefaults on issue_comment trigger CI Trigger notification resolved conflicts Fix AddEmail (#260) Merge branch 'master' into fix-AddEMail Add ListIssueCommentOptions for optional param (#243) Merge branch 'master' into impruve-ListXIssueComments Remove ListUserIssues() ... (#262) Merge branch 'master' into rm-ListUserIssues correct version (#257) Merge branch 'master' into targed-version Extend Issue Struct (#258) fix extend IssueTest add Repository to Issue struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/258 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Merge branch 'master' into targed-version format code (#245) fix if test is to fast remove lgtm bot config (gitea handle this now) format code Add GetIssueComment (#216) Merge branch 'master' into update-comment-api Fix & Refactor UserApp Functions (#247) Merge branch 'master' into refactor-user-app Add SearchRepo API Call (#254) Merge branch 'master' into search_repo IssueSubscribtion: Check http Status responce (#242) Merge branch 'master' into impruve-issueWatch Refactor RepoWatch (#241) Merge branch 'master' into refactor-repoWatch Add ListMilestoneOption to ListRepoMilestones (#244) use StateType use PageSize adjut test since gitea bug got fixed (#gitea/10047) add TestMilestones add optional ListMilestoneOption format Add ListOptions struct (#249) same struct as in models/list_options.go add mising license header add ListOptions struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/249 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: lafriks <lafriks@noreply.gitea.io> [README] add import path (#239) add import path add import path to readme Changelog v0.11.0 (#235) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/235 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: John Olheiser <john.olheiser@gmail.com> Add TestMyUser (#237) Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/237 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/239 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/244 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: Andrew Thornton <art27@cantab.net> Merge branch 'master' into refactor-repoWatch Add ListOptions struct (#249) same struct as in models/list_options.go add mising license header add ListOptions struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/249 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: lafriks <lafriks@noreply.gitea.io> add TEST fix GetMyWatchedRepos [README] add import path (#239) add import path add import path to readme Changelog v0.11.0 (#235) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/235 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: John Ol... Co-authored-by: Hilário Coelho <hilario.coelho@securityside.com> Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/205 Reviewed-by: 6543 <6543@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net>
lunny closed this pull request 3 years ago
lunny referenced this issue from a commit 3 years ago
Extend ListDeployKeys (#268) Merge branch 'master' into extend-ListDeployKeys added pagination options for listing requests (#205) fix golint issue small improvements ListMyRepos now receives a value instead of a pointer reverted makefile changes added sleep in order to increase CI stability resolved conflicts Use RepositoryMeta struct on Issues (#267) Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/267 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: techknowlogick <techknowlogick@gitea.io> extend SearchUsers (#248) Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: spawn2kill <spawn2kill@noreply.gitea.io> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/248 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Implement Repo Transfer (#264) fix test check version add TestRepoTransfer add TransferRepo Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/264 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Add notifications (#226) Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: spawn2kill <spawn2kill@noreply.gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/226 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> Use StateType (#265) use StateType Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/265 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: lafriks <lafriks@noreply.gitea.io> opt setDefaults on issue_comment trigger CI Trigger notification resolved conflicts Fix AddEmail (#260) Merge branch 'master' into fix-AddEMail Add ListIssueCommentOptions for optional param (#243) Merge branch 'master' into impruve-ListXIssueComments Remove ListUserIssues() ... (#262) Merge branch 'master' into rm-ListUserIssues correct version (#257) Merge branch 'master' into targed-version Extend Issue Struct (#258) fix extend IssueTest add Repository to Issue struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/258 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Merge branch 'master' into targed-version format code (#245) fix if test is to fast remove lgtm bot config (gitea handle this now) format code Add GetIssueComment (#216) Merge branch 'master' into update-comment-api Fix & Refactor UserApp Functions (#247) Merge branch 'master' into refactor-user-app Add SearchRepo API Call (#254) Merge branch 'master' into search_repo IssueSubscribtion: Check http Status responce (#242) Merge branch 'master' into impruve-issueWatch Refactor RepoWatch (#241) Merge branch 'master' into refactor-repoWatch Add ListMilestoneOption to ListRepoMilestones (#244) use StateType use PageSize adjut test since gitea bug got fixed (#gitea/10047) add TestMilestones add optional ListMilestoneOption format Add ListOptions struct (#249) same struct as in models/list_options.go add mising license header add ListOptions struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/249 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: lafriks <lafriks@noreply.gitea.io> [README] add import path (#239) add import path add import path to readme Changelog v0.11.0 (#235) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/235 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: John Olheiser <john.olheiser@gmail.com> Add TestMyUser (#237) Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/237 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/239 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/244 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: Andrew Thornton <art27@cantab.net> Merge branch 'master' into refactor-repoWatch Add ListOptions struct (#249) same struct as in models/list_options.go add mising license header add ListOptions struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/249 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: lafriks <lafriks@noreply.gitea.io> add TEST fix GetMyWatchedRepos [README] add import path (#239) add import path add import path to readme Changelog v0.11.0 (#235) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/235 Reviewed-by:... Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: spawn2kill <spawn2kill@noreply.gitea.io> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/268 Reviewed-by: lafriks <lafriks@noreply.gitea.io> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
6543 changed title from added pagination options for listing requests to Add Pagination Options for List Requests 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as e7bf8a6842.
Sign in to join this conversation.
Loading…
There is no content yet.