gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

[Add] VersionCheck #215

Merged
lafriks merged 12 commits from 6543/go-sdk:version-check into master 2020-01-27 06:20:55 +00:00
Conversation 14 Commits 12 Files Changed 9 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bd1193329e - Show all commits

2
gitea/client.go
View File

@ -21,7 +21,7 @@ var jsonHeader = http.Header{"content-type": []string{"application/json"}}
// Version return the library version
func Version() string {
return "0.11.0"
return "0.12.3"
zeripath commented 2020-01-06 19:44:05 +00:00
Outdated
Review
Copy Link

I don't think we can really reduce the version of the library - I see what you're trying to do though - maybe we should just make it 1.11.0?

I don't think we can really reduce the version of the library - I see what you're trying to do though - maybe we should just make it 1.11.0?
6543 commented 2020-01-07 01:13:56 +00:00
Outdated
Review
Copy Link

I dont like to go out of 0.x jet :https://medium.com/@aman.sardana/go-modules-versioning-dependency-management-d5f96b490774

"...version 0 is an exception for backward compatibility rule of golang as the version updated before version 1 can be backward incompatible. It is best for the libraries that are just starting. ..."

at this point we still can remove stuff ...
if we are sure that we stay in this structure we can go on to 1.x

I dont like to go out of 0.x jet :https://medium.com/@aman.sardana/go-modules-versioning-dependency-management-d5f96b490774 "...version 0 is an exception for backward compatibility rule of golang as the version updated before version 1 can be backward incompatible. It is best for the libraries that are just starting. ..." at this point we still can remove stuff ... if we are sure that we stay in this structure we can go on to 1.x
}
// Client represents a Gitea API client.