gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 8 Actions Releases 19 Activity

UrlEscape Function Arguments used in UrlPath #273

Merged
zeripath merged 18 commits from 6543/go-sdk:EscapeUserRepoNames into master 2021-03-21 20:20:33 +00:00
Conversation 9 Commits 18 Files Changed 47 +5 -8
4 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0a9af0f1b0 - Show all commits

4
gitea/issue_tracked_time.go
View File

@ -126,7 +126,7 @@ func (c *Client) ListIssueTrackedTimes(owner, repo string, index int64, opt List
// ResetIssueTime reset tracked time of a single issue for a given repository
func (c *Client) ResetIssueTime(owner, repo string, index int64) (*Response, error) {
if err := escapeValidatePathSegments(&owner, &repo); err != nil {
return nil, nil, err
return nil, err
}
_, resp, err := c.getResponse("DELETE", fmt.Sprintf("/repos/%s/%s/issues/%d/times", owner, repo, index), jsonHeader, nil)
return resp, err
@ -135,7 +135,7 @@ func (c *Client) ResetIssueTime(owner, repo string, index int64) (*Response, err
// DeleteTime delete a specific tracked time by id of a single issue for a given repository
func (c *Client) DeleteTime(owner, repo string, index, timeID int64) (*Response, error) {
if err := escapeValidatePathSegments(&owner, &repo); err != nil {
return nil, nil, err
return nil, err
}
_, resp, err := c.getResponse("DELETE", fmt.Sprintf("/repos/%s/%s/issues/%d/times/%d", owner, repo, index, timeID), jsonHeader, nil)
return resp, err

2
gitea/release.go
View File

@ -146,7 +146,7 @@ func (c *Client) DeleteRelease(user, repo string, id int64) (*Response, error) {
return nil, err
}
_, resp, err := c.getResponse("DELETE",
fmt.Sprintf("/repos/%s/%s/releases/%d", owner, repo, id),
fmt.Sprintf("/repos/%s/%s/releases/%d", user, repo, id),
nil, nil)
return resp, err
}

5
gitea/repo_file.go
View File

@ -173,7 +173,6 @@ func (c *Client) CreateFile(owner, repo, filepath string, opt CreateFileOptions)
return nil, nil, err
}
filepath = pathEscapeSegments(filepath)
var err error
if opt.BranchName, err = c.setDefaultBranchForOldVersions(owner, repo, opt.BranchName); err != nil {
return nil, nil, err
}
@ -194,7 +193,6 @@ func (c *Client) UpdateFile(owner, repo, filepath string, opt UpdateFileOptions)
return nil, nil, err
}
filepath = pathEscapeSegments(filepath)
var err error
if opt.BranchName, err = c.setDefaultBranchForOldVersions(owner, repo, opt.BranchName); err != nil {
return nil, nil, err
}
@ -212,10 +210,9 @@ func (c *Client) UpdateFile(owner, repo, filepath string, opt UpdateFileOptions)
func (c *Client) DeleteFile(owner, repo, filepath string, opt DeleteFileOptions) (*Response, error) {
err := escapeValidatePathSegments(&owner, &repo)
if err != nil {
return nil, nil, err
return nil, err
}
filepath = pathEscapeSegments(filepath)
var err error
if opt.BranchName, err = c.setDefaultBranchForOldVersions(owner, repo, opt.BranchName); err != nil {
return nil, err
}

2
gitea/status.go
View File

@ -97,7 +97,7 @@ func (c *Client) GetCombinedStatus(owner, repo, ref string) (*CombinedStatus, *R
return nil, nil, err
}
status := new(CombinedStatus)
resp, err := c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/commits/%s/status", owner, url.QueryEscape(ref), ref), jsonHeader, nil, status)
resp, err := c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/commits/%s/status", owner, repo, url.QueryEscape(ref)), jsonHeader, nil, status)
6543 marked this conversation as resolved Outdated
6543 commented 2021-03-08 21:56:19 +00:00
Outdated
Review
Copy Link

false params!

false params!
// gitea api return empty body if nothing here jet
if resp != nil && resp.StatusCode == 200 && err != nil {