gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Improve Error Handling #351

Merged
techknowlogick merged 6 commits from 6543/go-sdk:impruve-error-handling into master 2020-07-08 17:21:48 +00:00
Conversation 3 Commits 6 Files Changed 2 +2 -9
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 95a881223b - Show all commits

11
gitea/client.go
View File

@ -110,8 +110,6 @@ func (c *Client) getResponse(method, path string, header http.Header, body io.Re
return nil, err
}
errMap := make(map[string]interface{})
switch resp.StatusCode {
case 403:
return nil, errors.New("403 Forbidden")
@ -121,19 +119,14 @@ func (c *Client) getResponse(method, path string, header http.Header, body io.Re
return nil, errors.New("409 Conflict")
case 422:
return nil, fmt.Errorf("422 Unprocessable Entity: %s", string(data))
case 500:
if err = json.Unmarshal(data, &errMap); err != nil {
return nil, fmt.Errorf("500 Internal Server Error, request: '%s' with '%s' method '%s' header and '%s' body", path, method, header, string(data))
}
return nil, errors.New(errMap["message"].(string))
}
if resp.StatusCode/100 != 2 {
errMap := make(map[string]interface{})
jolheiser commented 2020-06-03 17:50:16 +00:00
Outdated
Review
Copy Link

Since this appears to be the same code as below, is there any way we can make a func for it or otherwise combine them to de-duplicate?

Since this appears to be the same code as below, is there any way we can make a func for it or otherwise combine them to de-duplicate?
6543 commented 2020-06-04 09:46:38 +00:00
Outdated
Review
Copy Link

if statement is, rest not

if statement is, rest not
6543 commented 2020-06-08 13:23:45 +00:00
Outdated
Review
Copy Link

@jolheiser I think this is to less code to make a own function - it would just make code more complex

@jolheiser I think this is to less code to make a own function - it would just make code more complex
if err = json.Unmarshal(data, &errMap); err != nil {
// when the JSON can't be parsed, data was probably empty or a plain string,
// so we try to return a helpful error anyway
return nil, fmt.Errorf("Unknown API Error: %d %s", resp.StatusCode, string(data))
return nil, fmt.Errorf("Unknown API Error: %d\nRequest: '%s' with '%s' method '%s' header and '%s' body", resp.StatusCode, path, method, header, string(data))
}
return nil, errors.New(errMap["message"].(string))
}