gitea/go-sdk
45
48
Fork 76
Code Issues 22 Pull Requests 10 Actions Releases 20 Activity

Update GetGlobalSettings Functions #376

Merged
6543 merged 2 commits from 6543/go-sdk:update_settings-endpoint into master 2020-06-30 20:29:14 +00:00
Conversation 4 Commits 2 Files Changed 2 +28 -13
6543 commented 2020-06-23 01:56:34 +00:00
Owner
Copy Link

based on https://github.com/go-gitea/gitea/pull/11854/files

close #374

based on https://github.com/go-gitea/gitea/pull/11854/files close #374
6543 added this to the v0.13.0 milestone 2020-06-23 01:56:34 +00:00
6543 added the
kind/enhancement
 label 2020-06-23 01:56:34 +00:00
6543 added 2 commits 2020-06-23 01:56:37 +00:00
extend Test
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4001b5af1e
6543 added the
status/needs-reviews
 label 2020-06-24 13:09:34 +00:00
lunny commented 2020-06-26 10:30:28 +00:00
Owner
Copy Link

This is a break change? Is that necessary?

This is a break change? Is that necessary?
6543 commented 2020-06-26 10:58:36 +00:00
Author
Owner
Copy Link

@lunny it is

@lunny it is
6543 commented 2020-06-26 10:59:16 +00:00
Author
Owner
Copy Link

and it the touched functions/structs got never released so it should be ok

and it the touched functions/structs got never released so it should be ok
techknowlogick approved these changes 2020-06-30 01:49:36 +00:00
Dismissed
gary-kim approved these changes 2020-06-30 15:18:56 +00:00
Dismissed
gary-kim left a comment
Member
Copy Link

Would be nice if it wasn't a breaking change but since it hasn't been tagged yet, hopefully, it's not too bad.

Would be nice if it wasn't a breaking change but since it hasn't been tagged yet, hopefully, it's not too bad.
6543 commented 2020-06-30 20:28:52 +00:00
Author
Owner
Copy Link

@gary-kim I agree - and thanks for looking at it :)

@gary-kim I agree - and thanks for looking at it :)
6543 merged commit c388803b68 into master 2020-06-30 20:29:14 +00:00
6543 deleted branch update_settings-endpoint 2020-06-30 20:29:21 +00:00
6543 removed the
status/needs-reviews
 label 2020-09-05 14:12:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.13.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#376
No description provided.
Delete Branch "6543/go-sdk:update_settings-endpoint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?