gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Replace IssueLabelsOption with []int64 #387

Closed
6543 wants to merge 2 commits from 6543:rm-IssueLabelsOption_366 into main
pull from: 6543:rm-IssueLabelsOption_366
merge into: gitea:main
Conversation 4 Commits 2 Files Changed 2 +18 -6
6543 commented 2020-07-27 14:22:10 +00:00
Owner
Copy Link

close #366

close #366
6543 added this to the v0.13.0 milestone 2020-07-27 14:22:10 +00:00
6543 added the
kind/breaking
kind/enhancement
 labels 2020-07-27 14:22:10 +00:00
6543 added 2 commits 2020-07-27 14:22:13 +00:00
add docu
All checks were successful
continuous-integration/drone/pr Build is passing
Details
03e5347cfe
6543 added the
status/needs-reviews
 label 2020-07-27 14:22:51 +00:00
lunny commented 2020-07-28 02:26:59 +00:00
Owner
Copy Link

I don't think expose the label's id is a good idea. maybe we should give all the label names.

I don't think expose the label's id is a good idea. maybe we should give all the label names.
6543 commented 2020-07-28 04:24:22 +00:00
Author
Owner
Copy Link

@lunny at the moment the api works that way

this only makes functions easyer to call but thats it

if we invent api v2 we can have eyes on not exposing IDs

@lunny at the moment the api works that way this only makes functions easyer to call but thats it if we invent api v2 we can have eyes on not exposing IDs
lunny commented 2020-07-30 11:55:33 +00:00
Owner
Copy Link

And why we need the change? A struct contains ids will be easier to add extra params in future?

And why we need the change? A struct contains ids will be easier to add extra params in future?
6543 commented 2020-07-30 12:42:32 +00:00
Author
Owner
Copy Link

it's more or less beauty correctio and extra params I think wont be added

I'll close it for now

it's more or less beauty correctio and extra params I think wont be added I'll close it for now
6543 closed this pull request 2020-07-30 12:42:33 +00:00
6543 removed this from the v0.13.0 milestone 2020-07-30 12:43:11 +00:00
6543 removed the
status/needs-reviews
 label 2020-07-30 12:43:22 +00:00
6543 deleted branch rm-IssueLabelsOption_366 2020-07-30 12:43:40 +00:00
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
testing / testing*
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#387
No description provided.
Delete Branch "6543:rm-IssueLabelsOption_366"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?