gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Milestone Functions accept name to identify #388

Closed
6543 wants to merge 11 commits from 6543:GetMilestones_add-name-to-id-resove-function into main
pull from: 6543:GetMilestones_add-name-to-id-resove-function
merge into: gitea:main
Conversation 6 Commits 11 Files Changed 2 +85 -9
6543 commented 2020-07-28 12:47:47 +00:00
Owner
Copy Link

close #383

close #383
6543 added 3 commits 2020-07-28 12:47:52 +00:00
better func name
Some checks failed
continuous-integration/drone/pr Build is failing
Details
bb86f65f01
6543 added 1 commit 2020-07-28 16:07:18 +00:00
Fix LINT
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
6cf5b7df12
6543 added 1 commit 2020-07-28 16:19:02 +00:00
fix & add test
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
79d21b5bea
6543 added 1 commit 2020-07-28 16:20:53 +00:00
rm var only used once
All checks were successful
continuous-integration/drone/pr Build is passing
Details
091c686f6a
6543 added 1 commit 2020-07-28 16:29:04 +00:00
handle non existing milestone names
All checks were successful
continuous-integration/drone/pr Build is passing
Details
65f97c8574
6543 added 1 commit 2020-07-28 16:39:04 +00:00
ResolveMileIDbyName -> ResolveMilestoneIDByName
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d060eecb7b
6543 added this to the v0.13.0 milestone 2020-07-28 16:43:00 +00:00
6543 added the
kind/enhancement
status/needs-reviews
 labels 2020-07-28 16:43:23 +00:00
techknowlogick approved these changes 2020-07-30 19:55:58 +00:00
Dismissed
techknowlogick left a comment
Owner
Copy Link

This LGTM, but I think we should start to move to different error types instead of just comparing error strings (this isn't a blocker though for this PR)

This LGTM, but I think we should start to move to different error types instead of just comparing error strings (this isn't a blocker though for this PR)
6543 added 1 commit 2020-07-31 06:45:59 +00:00
Merge branch 'master' into GetMilestones_add-name-to-id-resove-function
All checks were successful
continuous-integration/drone/pr Build is passing
Details
21dd25dc52
6543 commented 2020-07-31 06:46:32 +00:00
Author
Owner
Copy Link

@techknowlogick #361 was ment to fix it but it looks like I have to submit my own one

@techknowlogick #361 was ment to fix it but it looks like I have to submit my own one
👍 1
lunny reviewed 2020-08-20 01:57:28 +00:00
Dismissed
gitea/issue_milestone.go Outdated
@ -134,0 +164,4 @@
i := 0
for {
i++
miles, err := c.ListRepoMilestones(owner, repo, ListMilestoneOption{
lunny commented 2020-08-20 01:57:28 +00:00
Owner
Copy Link

This is really low efficient.

This is really low efficient.
6543 commented 2020-08-29 23:19:48 +00:00
Author
Owner
Copy Link

@lunny only on old instances - but I'm thinking we should do something similar for milestones as we did for tokens with https://github.com/go-gitea/gitea/pull/12366

@lunny only on old instances - but I'm thinking we should do something similar for milestones as we did for tokens with https://github.com/go-gitea/gitea/pull/12366
6543 commented 2020-08-29 23:28:46 +00:00
Author
Owner
Copy Link

while waiting for things ... exract update to #393

while waiting for things ... exract update to #393
6543 commented 2020-08-30 12:08:49 +00:00
Author
Owner
Copy Link

-> https://github.com/go-gitea/gitea/pull/12649

-> https://github.com/go-gitea/gitea/pull/12649
6543 commented 2020-08-30 12:09:39 +00:00
Author
Owner
Copy Link

I think we should keep the resolve function for backwards (gitea <= 1.12) compatibilety but unexposed

I think we should keep the resolve function for backwards (gitea <= 1.12) compatibilety but unexposed
6543 added
status/blocked
upstream/gitea
 and removed
status/needs-reviews
 labels 2020-08-30 21:31:57 +00:00
6543 added
status/wip
kind/feature
 and removed
upstream/gitea
kind/enhancement
 labels 2020-09-05 04:00:05 +00:00
6543 added 2 commits 2020-09-05 04:13:28 +00:00
take use of https://github.com/go-gitea/gitea/pull/12649
Some checks failed
continuous-integration/drone/pr Build is failing
Details
67d2a14d0d
6543 commented 2020-09-05 04:14:01 +00:00
Author
Owner
Copy Link

blocked by https://github.com/go-gitea/gitea/pull/12649

blocked by https://github.com/go-gitea/gitea/pull/12649
6543 removed the
status/wip
 label 2020-09-05 04:14:15 +00:00
6543 removed the
status/blocked
 label 2020-09-14 17:02:35 +00:00
6543 closed this pull request 2020-09-14 17:43:28 +00:00
6543 removed the
kind/feature
 label 2020-09-14 17:45:10 +00:00
6543 removed this from the v0.13.0 milestone 2020-09-14 17:45:17 +00:00
6543 commented 2020-09-14 17:46:34 +00:00
Author
Owner
Copy Link

@techknowlogick created new pull because this one is a mess now ... and
gitea currently dont work with forcepush to pull

-> #418

@techknowlogick created new pull because this one is a mess now ... and gitea currently dont work with forcepush to pull -> #418
Some checks are pending
continuous-integration/drone/pr Build is failing
Details
testing / testing*
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#388
No description provided.
Delete Branch "6543:GetMilestones_add-name-to-id-resove-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?