Milestone Functions accept name to identify #388

Closed
6543 wants to merge 11 commits from 6543:GetMilestones_add-name-to-id-resove-function into main
6543 commented 2 years ago
Collaborator

close #383

close #383
6543 added 3 commits 2 years ago
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build was killed Details
6cf5b7df12
Fix LINT
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build was killed Details
79d21b5bea
fix & add test
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
091c686f6a
rm var only used once
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
65f97c8574
handle non existing milestone names
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
d060eecb7b
ResolveMileIDbyName -> ResolveMilestoneIDByName
6543 added this to the v0.13.0 milestone 2 years ago
6543 added the kind/enhancement status/needs-reviews labels 2 years ago
techknowlogick approved these changes 2 years ago
Dismissed
techknowlogick left a comment
Owner

This LGTM, but I think we should start to move to different error types instead of just comparing error strings (this isn't a blocker though for this PR)

This LGTM, but I think we should start to move to different error types instead of just comparing error strings (this isn't a blocker though for this PR)
6543 added 1 commit 2 years ago
Poster
Collaborator

@techknowlogick #361 was ment to fix it but it looks like I have to submit my own one

@techknowlogick #361 was ment to fix it but it looks like I have to submit my own one
lunny reviewed 2 years ago
Dismissed
i := 0
for {
i++
miles, err := c.ListRepoMilestones(owner, repo, ListMilestoneOption{
Owner

This is really low efficient.

This is really low efficient.
Poster
Collaborator

@lunny only on old instances - but I'm thinking we should do something similar for milestones as we did for tokens with https://github.com/go-gitea/gitea/pull/12366

@lunny only on old instances - but I'm thinking we should do something similar for milestones as we did for tokens with https://github.com/go-gitea/gitea/pull/12366
Poster
Collaborator

while waiting for things ... exract update to #393

while waiting for things ... exract update to #393
Poster
Collaborator
-> https://github.com/go-gitea/gitea/pull/12649
Poster
Collaborator

I think we should keep the resolve function for backwards (gitea <= 1.12) compatibilety but unexposed

I think we should keep the resolve function for backwards (gitea <= 1.12) compatibilety but unexposed
6543 added status/blocked upstream/gitea and removed status/needs-reviews labels 2 years ago
6543 added status/wip kind/feature and removed upstream/gitea kind/enhancement labels 2 years ago
6543 added 2 commits 2 years ago
Poster
Collaborator
blocked by https://github.com/go-gitea/gitea/pull/12649
6543 removed the status/wip label 2 years ago
6543 removed the status/blocked label 2 years ago
6543 closed this pull request 2 years ago
6543 removed the kind/feature label 2 years ago
6543 removed this from the v0.13.0 milestone 2 years ago
Poster
Collaborator

@techknowlogick created new pull because this one is a mess now ... and
gitea currently dont work with forcepush to pull

-> #418

@techknowlogick created new pull because this one is a mess now ... and gitea currently dont work with forcepush to pull -> #418
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Loading…
There is no content yet.