Add Helper for Optional Values #448

Merged
6543 merged 4 commits from 6543/go-sdk:add-bool-helper into master 2020-11-12 21:27:29 +00:00
Owner

close #340

close #340
6543 added this to the v0.14.0 milestone 2020-11-09 17:09:23 +00:00
6543 added the
kind/enhancement
label 2020-11-09 17:09:23 +00:00
6543 force-pushed add-bool-helper from b1618b30cc to a05b2d9fb9 2020-11-09 17:16:23 +00:00 Compare
6543 force-pushed add-bool-helper from a05b2d9fb9 to 82ccd068f4 2020-11-09 17:17:37 +00:00 Compare
6543 added the
status/needs-feedback
status/needs-reviews
labels 2020-11-09 17:18:50 +00:00
jolheiser reviewed 2020-11-12 20:54:28 +00:00
Dismissed
gitea/helper.go Outdated
@ -0,0 +5,4 @@
package gitea
// OptionalTrue return reference of true for a optional bool
func OptionalTrue() *bool {
Owner

I'm not sure I like the abstraction for a few lines of code...
Also, small nit, but why not OptionalBool(b bool) for consistency with the other methods?

I'm not sure I like the abstraction for a few lines of code... Also, small nit, but why not `OptionalBool(b bool)` for consistency with the other methods?
6543 marked this conversation as resolved
zeripath approved these changes 2020-11-12 20:55:50 +00:00
Dismissed
jolheiser approved these changes 2020-11-12 20:58:44 +00:00
Dismissed
jolheiser left a comment
Owner

I won't block just for my nits.

I won't block just for my nits.
Author
Owner

@jolheiser no It's a good suggestions - since I mostly work alone on this ... hearing idears and thougts about souch things is alwasy a good input for me 👍

@jolheiser no It's a good suggestions - since I mostly work alone on this ... hearing idears and thougts about souch things is alwasy a good input for me :+1:
Author
Owner

thats why I put the "need-feedback" lable on ... will change it to OptionalBool

thats why I put the "need-feedback" lable on ... will change it to OptionalBool
6543 force-pushed add-bool-helper from be37a86e89 to 7c47bdb50b 2020-11-12 21:14:06 +00:00 Compare
6543 added 1 commit 2020-11-12 21:21:04 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
358ff2b0dd
Merge branch 'master' into add-bool-helper
6543 removed the
status/needs-feedback
label 2020-11-12 21:21:16 +00:00
6543 merged commit aa13606bc6 into master 2020-11-12 21:27:28 +00:00
6543 deleted branch add-bool-helper 2020-11-12 21:27:35 +00:00
Sign in to join this conversation.
No description provided.