Add Helper for Optional Values #448

Merged
6543 merged 4 commits from 6543/go-sdk:add-bool-helper into master 1 year ago
6543 commented 1 year ago
Collaborator

close #340

close #340
6543 added this to the v0.14.0 milestone 1 year ago
6543 added the
kind/enhancement
label 1 year ago
6543 force-pushed add-bool-helper from b1618b30cc to a05b2d9fb9 1 year ago
6543 force-pushed add-bool-helper from a05b2d9fb9 to 82ccd068f4 1 year ago
6543 added the
status/needs-feedback
status/needs-reviews
labels 1 year ago
jolheiser reviewed 1 year ago
Dismissed
gitea/helper.go Outdated
package gitea
// OptionalTrue return reference of true for a optional bool
func OptionalTrue() *bool {
Collaborator

I'm not sure I like the abstraction for a few lines of code...
Also, small nit, but why not OptionalBool(b bool) for consistency with the other methods?

I'm not sure I like the abstraction for a few lines of code... Also, small nit, but why not `OptionalBool(b bool)` for consistency with the other methods?
6543 marked this conversation as resolved
zeripath approved these changes 1 year ago
Dismissed
jolheiser approved these changes 1 year ago
Dismissed
jolheiser left a comment

I won't block just for my nits.

6543 commented 1 year ago
Poster
Collaborator

@jolheiser no It's a good suggestions - since I mostly work alone on this ... hearing idears and thougts about souch things is alwasy a good input for me 👍

@jolheiser no It's a good suggestions - since I mostly work alone on this ... hearing idears and thougts about souch things is alwasy a good input for me :+1:
6543 commented 1 year ago
Poster
Collaborator

thats why I put the "need-feedback" lable on ... will change it to OptionalBool

thats why I put the "need-feedback" lable on ... will change it to OptionalBool
6543 force-pushed add-bool-helper from be37a86e89 to 7c47bdb50b 1 year ago
6543 added 1 commit 1 year ago
358ff2b0dd Merge branch 'master' into add-bool-helper
6543 removed the
status/needs-feedback
label 1 year ago
6543 referenced this issue from a commit 1 year ago
6543 merged commit aa13606bc6 into master 1 year ago
6543 deleted branch add-bool-helper 1 year ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as aa13606bc6.
Sign in to join this conversation.
Loading…
There is no content yet.