make test-instance Support for MacOS & different architectures #450

Merged
6543 merged 3 commits from 6543/go-sdk:make_test-instance into master 2020-11-09 20:55:00 +00:00
Owner

close #269

For Reviewers (HowTo test):

  1. Open first terminal and exec make test-instance
  2. Wait some seconds
  3. Open second terminal and exec make test
close #269 For Reviewers (HowTo test): 1. Open first terminal and exec `make test-instance` 2. Wait some seconds 3. Open second terminal and exec `make test`
6543 added this to the v0.14.0 milestone 2020-11-09 17:40:28 +00:00
6543 added the
kind/testing
kind/build
skip-changelog
labels 2020-11-09 17:40:28 +00:00
6543 added 1 commit 2020-11-09 17:40:29 +00:00
make test-instance: Support for MacOS & different architectures
All checks were successful
continuous-integration/drone/pr Build is passing
59f35059ab
6543 added 1 commit 2020-11-09 17:41:19 +00:00
fix
All checks were successful
continuous-integration/drone/pr Build is passing
e123f64721
6543 changed title from `make test-instance:` Support for MacOS & different architectures to `make test-instance` Support for MacOS & different architectures 2020-11-09 17:42:05 +00:00
6543 added the
status/needs-reviews
label 2020-11-09 17:53:11 +00:00
mrsdizzie reviewed 2020-11-09 18:38:37 +00:00
Dismissed
Makefile Outdated
@ -9,0 +15,4 @@
ifeq ($(UNAME_S),Darwin)
GITEA_DL := $(GITEA_DL)darwin-10.6-
endif
UNAME_P := $(shell uname -p)
Member

uname -p is not reliable for Mac. It will show i386 but it is not. Also we don't have 386 binary for mac so it fails:

--2020-11-09 13:31:36--  https://dl.gitea.io/gitea/master/gitea-master-darwin-10.6-386
Resolving dl.gitea.io (dl.gitea.io)... 147.75.84.81, 2604:1380:2000:c600::5
Connecting to dl.gitea.io (dl.gitea.io)|147.75.84.81|:443... connected.
HTTP request sent, awaiting response... 404 Not Found

Mac should always be gitea-master-darwin-10.6-amd64

```uname -p ``` is not reliable for Mac. It will show i386 but it is not. Also we don't have 386 binary for mac so it fails: ```wget --2020-11-09 13:31:36-- https://dl.gitea.io/gitea/master/gitea-master-darwin-10.6-386 Resolving dl.gitea.io (dl.gitea.io)... 147.75.84.81, 2604:1380:2000:c600::5 Connecting to dl.gitea.io (dl.gitea.io)|147.75.84.81|:443... connected. HTTP request sent, awaiting response... 404 Not Found ``` Mac should always be gitea-master-darwin-10.6-amd64
6543 marked this conversation as resolved
6543 added 1 commit 2020-11-09 19:13:19 +00:00
detect arch only on linux
All checks were successful
continuous-integration/drone/pr Build is passing
4ec30903a7
mrsdizzie approved these changes 2020-11-09 19:33:08 +00:00
Dismissed
mrsdizzie left a comment
Member

Works for me on MacOS -- it redownloads the gitea binary each time you run make test-instance so maybe it could check if there is already one there first ?

Works for me on MacOS -- it redownloads the gitea binary each time you run make test-instance so maybe it could check if there is already one there first ?
zeripath approved these changes 2020-11-09 19:49:07 +00:00
Dismissed
6543 merged commit 623a9eb4bf into master 2020-11-09 20:55:00 +00:00
6543 deleted branch make_test-instance 2020-11-09 20:55:08 +00:00
6543 removed the
status/needs-reviews
label 2020-11-10 09:09:28 +00:00
Sign in to join this conversation.
No description provided.