`make test-instance` Support for MacOS & different architectures #450

Merged
6543 merged 3 commits from 6543/go-sdk:make_test-instance into master 2 years ago
6543 commented 2 years ago
Collaborator

close #269

For Reviewers (HowTo test):

  1. Open first terminal and exec make test-instance
  2. Wait some seconds
  3. Open second terminal and exec make test
close #269 For Reviewers (HowTo test): 1. Open first terminal and exec `make test-instance` 2. Wait some seconds 3. Open second terminal and exec `make test`
6543 added this to the v0.14.0 milestone 2 years ago
6543 added the
kind/testing
kind/build
skip-changelog
labels 2 years ago
6543 added 1 commit 2 years ago
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
e123f64721
fix
6543 changed title from `make test-instance:` Support for MacOS & different architectures to `make test-instance` Support for MacOS & different architectures 2 years ago
6543 added the
status/needs-reviews
label 2 years ago
mrsdizzie reviewed 2 years ago
Dismissed
Makefile Outdated
ifeq ($(UNAME_S),Darwin)
GITEA_DL := $(GITEA_DL)darwin-10.6-
endif
UNAME_P := $(shell uname -p)
Collaborator

uname -p is not reliable for Mac. It will show i386 but it is not. Also we don't have 386 binary for mac so it fails:

--2020-11-09 13:31:36--  https://dl.gitea.io/gitea/master/gitea-master-darwin-10.6-386
Resolving dl.gitea.io (dl.gitea.io)... 147.75.84.81, 2604:1380:2000:c600::5
Connecting to dl.gitea.io (dl.gitea.io)|147.75.84.81|:443... connected.
HTTP request sent, awaiting response... 404 Not Found

Mac should always be gitea-master-darwin-10.6-amd64

```uname -p ``` is not reliable for Mac. It will show i386 but it is not. Also we don't have 386 binary for mac so it fails: ```wget --2020-11-09 13:31:36-- https://dl.gitea.io/gitea/master/gitea-master-darwin-10.6-386 Resolving dl.gitea.io (dl.gitea.io)... 147.75.84.81, 2604:1380:2000:c600::5 Connecting to dl.gitea.io (dl.gitea.io)|147.75.84.81|:443... connected. HTTP request sent, awaiting response... 404 Not Found ``` Mac should always be gitea-master-darwin-10.6-amd64
6543 marked this conversation as resolved
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
4ec30903a7
detect arch only on linux
mrsdizzie approved these changes 2 years ago
Dismissed
mrsdizzie left a comment
Collaborator

Works for me on MacOS -- it redownloads the gitea binary each time you run make test-instance so maybe it could check if there is already one there first ?

Works for me on MacOS -- it redownloads the gitea binary each time you run make test-instance so maybe it could check if there is already one there first ?
zeripath approved these changes 2 years ago
Dismissed
6543 merged commit 623a9eb4bf into master 2 years ago
6543 deleted branch make_test-instance 2 years ago
6543 removed the
status/needs-reviews
label 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 623a9eb4bf.
Sign in to join this conversation.
Loading…
There is no content yet.