Remove & Rename TrackedTimes list functions #467

Merged
6543 merged 8 commits from 6543/go-sdk:rm_GetUserTrackedTimes-and-more into master 10 months ago
6543 commented 11 months ago
Collaborator

close #465

close #465
6543 added 3 commits 11 months ago
6543 added 1 commit 11 months ago
b217cc59a9
insert pull index
6543 reviewed 11 months ago
Dismissed
<!-- tocstop -->
## Remove Functions for deprecated endpoints
6543 commented 11 months ago
Poster
Collaborator

Removed ... of ...

?

Removed ... of ... ?
6543 marked this conversation as resolved
6543 added the
kind/breaking
kind/enhancement
labels 11 months ago
6543 added this to the v0.14.0 milestone 11 months ago
noerw reviewed 11 months ago
Dismissed
// GetRepoTrackedTimesOptions set optional filters
type GetRepoTrackedTimesOptions struct {
User string
}
Poster

This needs ListOptions as well, and ideally also since and before (accepting RFC 3339 dates).

Same for ListTrackedTimesOptions (they are equal I think, no need for a new type?)

This needs `ListOptions` as well, and ideally also `since` and `before` (accepting RFC 3339 dates). Same for `ListTrackedTimesOptions` (they are equal I think, no need for a new type?)
6543 marked this conversation as resolved
noerw changed title from Remove Getusertrackedtimes() and add options to GetRepoTrackedTimes() to Remove GetUserTrackedTimes() and add options to GetRepoTrackedTimes() 10 months ago
6543 force-pushed rm_GetUserTrackedTimes-and-more from b217cc59a9 to 6d9f68915a 10 months ago
6543 added 1 commit 10 months ago
2754d5ded9
rename ListTrackedTimes -> ListIssueTrackedTimes
6543 force-pushed rm_GetUserTrackedTimes-and-more from 2754d5ded9 to b001650be7 10 months ago
6543 changed title from Remove GetUserTrackedTimes() and add options to GetRepoTrackedTimes() to Remove & Rename TrackedTimes list functions 10 months ago
6543 added 1 commit 10 months ago
a637682232
update pull title
Poster
Collaborator

@noerw did a big refactor + add filters

@noerw did a big refactor + add filters
6543 reviewed 10 months ago
Dismissed
ListOptions
Since time.Time
Before time.Time
// User filter is only used by ListRepoTrackedTimes !!!
6543 commented 10 months ago
Poster
Collaborator

we shold add this filter for issues too -> Upstream TODO

we shold add this filter for issues too -> Upstream TODO
6543 commented 10 months ago
Poster
Collaborator
created upstream issue: https://github.com/go-gitea/gitea/issues/14024
noerw reviewed 10 months ago
Dismissed
Poster

you're now passing jsonHeader unlike before, is this intended?

you're now passing `jsonHeader` unlike before, is this intended?
6543 marked this conversation as resolved
6543 added 1 commit 10 months ago
91bf0c7134
add jsonHeader on all tt func
Poster
Collaborator

you're now passing jsonHeader unlike before, is this intended?

most gitea api endpoints do not care if this header is set or not, but it's a good habit.

a client should indicate what "language" he speaks

> you're now passing `jsonHeader` unlike before, is this intended? **most** gitea api endpoints do not care if this header is set or not, but it's a good habit. a client should indicate what "language" he speaks
noerw approved these changes 10 months ago
Dismissed
6543 added the
status/needs-reviews
label 10 months ago
lunny approved these changes 10 months ago
Dismissed
lunny added 1 commit 10 months ago
6543 merged commit e34d140607 into master 10 months ago
6543 deleted branch rm_GetUserTrackedTimes-and-more 10 months ago
6543 removed the
status/needs-reviews
label 10 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as e34d140607.
Sign in to join this conversation.
Loading…
There is no content yet.