Improve PullReview docs #469

Merged
6543 merged 5 commits from :review-docs into master 2020-12-17 10:14:17 +00:00
Member
No description provided.
noerw added 1 commit 2020-12-16 17:05:06 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
edb96f2f29
document some PullReview fields
6543 requested changes 2020-12-16 17:09:32 +00:00
Dismissed
@ -45,0 +38,4 @@
State ReviewStateType `json:"state"`
Body string `json:"body"`
CommitID string `json:"commit_id"`
// Stale indicates if the review was made on an earlier commit
Owner

it doesnt care of commit, it care if pull has changed since reviewed

it doesnt care of commit, it care if pull has changed since reviewed
6543 marked this conversation as resolved
@ -45,0 +40,4 @@
CommitID string `json:"commit_id"`
// Stale indicates if the review was made on an earlier commit
Stale bool `json:"stale"`
// Official indicates if the review counts towards the required approval limit
Owner

if it is made to a protected branch

if it is made to a protected branch
6543 marked this conversation as resolved
6543 added the
kind/docs
label 2020-12-16 17:09:46 +00:00
6543 added this to the v0.14.0 milestone 2020-12-16 17:09:55 +00:00
noerw added 1 commit 2020-12-16 17:13:41 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
b77f66a31f
code review
6543 approved these changes 2020-12-16 17:17:50 +00:00
Dismissed
Owner

@noerw "update branch" ;)

@noerw "update branch" ;)
noerw added 1 commit 2020-12-16 17:21:48 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
d28df0ed50
Merge branch 'master' into review-docs
lunny approved these changes 2020-12-17 04:49:57 +00:00
Dismissed
lunny added 1 commit 2020-12-17 04:50:01 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
4923a0faf9
Merge branch 'master' into review-docs
6543 added 1 commit 2020-12-17 10:06:26 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
59c679cffb
Merge branch 'master' into review-docs
6543 merged commit 97e61e5a8a into master 2020-12-17 10:14:17 +00:00
6543 referenced this issue from a commit 2020-12-17 10:14:17 +00:00
noerw deleted branch review-docs 2020-12-17 13:32:16 +00:00
Sign in to join this conversation.
No description provided.