Improve PullReview docs #469

Merged
6543 merged 5 commits from :review-docs into master 10 months ago
noerw commented 10 months ago
There is no content yet.
noerw added 1 commit 10 months ago
edb96f2f29
document some PullReview fields
6543 requested changes 10 months ago
Dismissed
State ReviewStateType `json:"state"`
Body string `json:"body"`
CommitID string `json:"commit_id"`
// Stale indicates if the review was made on an earlier commit
6543 commented 10 months ago
Poster
Collaborator

it doesnt care of commit, it care if pull has changed since reviewed

it doesnt care of commit, it care if pull has changed since reviewed
6543 marked this conversation as resolved
CommitID string `json:"commit_id"`
// Stale indicates if the review was made on an earlier commit
Stale bool `json:"stale"`
// Official indicates if the review counts towards the required approval limit
6543 commented 10 months ago
Poster
Collaborator

if it is made to a protected branch

if it is made to a protected branch
6543 marked this conversation as resolved
6543 added the
kind/docs
label 10 months ago
6543 added this to the v0.14.0 milestone 10 months ago
noerw added 1 commit 10 months ago
b77f66a31f
code review
6543 approved these changes 10 months ago
Dismissed
Collaborator

@noerw "update branch" ;)

@noerw "update branch" ;)
noerw added 1 commit 10 months ago
d28df0ed50 Merge branch 'master' into review-docs
lunny approved these changes 10 months ago
Dismissed
lunny added 1 commit 10 months ago
4923a0faf9 Merge branch 'master' into review-docs
6543 added 1 commit 10 months ago
59c679cffb Merge branch 'master' into review-docs
6543 merged commit 97e61e5a8a into master 10 months ago
6543 referenced this issue from a commit 10 months ago
noerw deleted branch review-docs 10 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 97e61e5a8a.
Sign in to join this conversation.
Loading…
There is no content yet.