Fix GetCombinedStatus() #470

Merged
lunny merged 7 commits from :fix-468 into master 10 months ago
noerw commented 10 months ago

fixes #468

fixes #468
noerw added 3 commits 10 months ago
edb96f2f29
document some PullReview fields
b77f66a31f
code review
ff420d35f8
fix broken GetCombinedStatus
noerw added the
kind/bug
label 10 months ago
noerw force-pushed fix-468 from ff420d35f8 to ef5beaf553 10 months ago
Collaborator
there exist * https://gitea.com/api/swagger#/repository/repoGetCombinedStatusByRef * https://gitea.com/api/swagger#/repository/repoListStatuses I think we have to fix **ListStatuses** too!!
6543 added the
need/backport
label 10 months ago
6543 added this to the v0.14.0 milestone 10 months ago
6543 self-assigned this 10 months ago
6543 added 2 commits 10 months ago
6543 changed title from fix broken GetCombinedStatus() to Fix GetCombinedStatus() and ListStatuses() 10 months ago
Collaborator
  • TODO: tests
* TODO: tests
6543 added 1 commit 10 months ago
64e7ed12fd
Add Tests
6543 added 1 commit 10 months ago
da955d648e
enable tests for GetCombinedStatus()
6543 added 1 commit 10 months ago
c8b1e7dc03
next fix
6543 added 1 commit 10 months ago
bfee1fee14
final fix
6543 changed title from Fix GetCombinedStatus() and ListStatuses() to Fix GetCombinedStatus() 10 months ago
Collaborator

the big issue here was gitea's api documentation!

https://github.com/go-gitea/gitea/pull/14026 will fix this & more

the big issue here was gitea's api documentation! https://github.com/go-gitea/gitea/pull/14026 will fix this & more
6543 approved these changes 10 months ago
Dismissed
Collaborator

@noerw since I did a lot on this pull - I thik your lgtm would be good too

@noerw since I did a lot on this pull - I thik your lgtm would be good too
Collaborator

coverage: 51.1% -> 52.0% 🎉

`coverage: 51.1% -> 52.0%` 🎉
lunny approved these changes 10 months ago
Dismissed
lunny merged commit 7ddbf1a015 into master 10 months ago
lunny referenced this issue from a commit 10 months ago
6543 referenced this issue from a commit 10 months ago
Collaborator

Backport -> #472

Backport -> #472
6543 added
has/backport
and removed
need/backport
labels 10 months ago
lunny referenced this issue from a commit 10 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 7ddbf1a015.
Sign in to join this conversation.
Loading…
There is no content yet.