Update Structs #486

Merged
6543 merged 18 commits from 6543/go-sdk:update-structs into master 9 months ago
6543 commented 9 months ago
Collaborator
  • FileOptions: add Signoff
  • Commit: add CommitAffectedFiles
  • BranchProtection, CreateBranchProtectionOption, EditBranchProtectionOption: add BlockOnOfficialReviewRequests
  • MigrateRepoOption: add MirrorInterval & enable gogs as source option
  • EditRepoOption: Add new fields
  • Repository: Add new fields & related structs
  • PullReview: Add fields
  • StopWatch: Add new fields
  • EditIssueOption: Add option to delete Deadline
  • EditUserOption: lot of options got optional

close #479

* FileOptions: add Signoff * Commit: add CommitAffectedFiles * BranchProtection, CreateBranchProtectionOption, EditBranchProtectionOption: add BlockOnOfficialReviewRequests * MigrateRepoOption: add MirrorInterval & enable gogs as source option * EditRepoOption: Add new fields * Repository: Add new fields & related structs * PullReview: Add fields * StopWatch: Add new fields * EditIssueOption: Add option to delete Deadline * EditUserOption: lot of options got optional close #479
6543 added this to the v0.14.0 milestone 9 months ago
6543 added 11 commits 9 months ago
6543 added the
kind/enhancement
kind/breaking
labels 9 months ago
Poster
Collaborator

-> EditUserOption: lot of options got optional breaking!

-> EditUserOption: lot of options got optional **breaking!**
6543 force-pushed update-structs from 9747aff8b8 to 62bf840fae 9 months ago
6543 added 1 commit 9 months ago
7417c4b8e2
Add migration hints for breaking change
6543 added 1 commit 9 months ago
f73d506d8b Merge branch 'master' into update-structs
6543 added 1 commit 9 months ago
fb8a671da2 impruve docs
lunny approved these changes 9 months ago
Dismissed
zeripath reviewed 9 months ago
Dismissed
- [#467 Remove & Rename TrackedTimes list functions](https://gitea.com/gitea/go-sdk/pulls/467)
## Some Fields of Structs got optional
Poster
Collaborator

New Optional Fields

New Optional Fields
6543 marked this conversation as resolved
zeripath reviewed 9 months ago
Dismissed
The EditUserOption struct is only affected currently.
For example Email type changed from `string` to `*string`.
The easyest migration path is, to war your options with:
Poster
Collaborator

s/easyest/easiest

I don't understand to war your options with?

s/easyest/easiest I don't understand `to war your options with`?
6543 marked this conversation as resolved
zeripath reviewed 9 months ago
Dismissed
}
case GitServiceGogs:
if len(opt.AuthToken) == 0 {
return fmt.Errorf("gogs require token authentication")
Poster
Collaborator

gogs requires token authentication

gogs require**s** token authentication
6543 marked this conversation as resolved
6543 added 1 commit 9 months ago
72914776ae X requires token authentication
6543 added 1 commit 9 months ago
578a56b7eb New Optional Fields
zeripath reviewed 9 months ago
Dismissed
## New Optional Fields
`EditUserOption` struct is has gained several new Optional fields.
Poster
Collaborator

The EditUserOption struct has gained several new Optional fields.

The `EditUserOption` struct has gained several new Optional fields.
6543 marked this conversation as resolved
6543 added 1 commit 9 months ago
2d5e3f4a51 next
zeripath approved these changes 9 months ago
Dismissed
zeripath left a comment

Apart from the double period at the end of the line. LGTM.

## New Optional Fields
The `EditUserOption` struct has gained several new Optional fields..
Poster
Collaborator

oops double terminal period here

oops double terminal period here
6543 marked this conversation as resolved
6543 added 1 commit 9 months ago
48ff1a903a next-try
6543 merged commit 8947cd3b00 into master 9 months ago
6543 referenced this issue from a commit 9 months ago
6543 deleted branch update-structs 9 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 8947cd3b00.
Sign in to join this conversation.
Loading…
There is no content yet.