gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Update Structs #486

Merged
6543 merged 18 commits from 6543/go-sdk:update-structs into master 2021-02-13 19:24:01 +00:00
Conversation 1 Commits 18 Files Changed 11 +239 -152
6543 commented 2021-02-12 22:05:14 +00:00
Owner
Copy Link
  • FileOptions: add Signoff
  • Commit: add CommitAffectedFiles
  • BranchProtection, CreateBranchProtectionOption, EditBranchProtectionOption: add BlockOnOfficialReviewRequests
  • MigrateRepoOption: add MirrorInterval & enable gogs as source option
  • EditRepoOption: Add new fields
  • Repository: Add new fields & related structs
  • PullReview: Add fields
  • StopWatch: Add new fields
  • EditIssueOption: Add option to delete Deadline
  • EditUserOption: lot of options got optional

close #479

* FileOptions: add Signoff * Commit: add CommitAffectedFiles * BranchProtection, CreateBranchProtectionOption, EditBranchProtectionOption: add BlockOnOfficialReviewRequests * MigrateRepoOption: add MirrorInterval & enable gogs as source option * EditRepoOption: Add new fields * Repository: Add new fields & related structs * PullReview: Add fields * StopWatch: Add new fields * EditIssueOption: Add option to delete Deadline * EditUserOption: lot of options got optional close #479
6543 added this to the v0.14.0 milestone 2021-02-12 22:05:14 +00:00
6543 added 1 commit 2021-02-12 22:05:14 +00:00
6543 added the
kind/enhancement
kind/breaking
 labels 2021-02-12 22:06:42 +00:00
6543 commented 2021-02-12 22:07:12 +00:00
Author
Owner
Copy Link

-> EditUserOption: lot of options got optional breaking!

-> EditUserOption: lot of options got optional **breaking!**
6543 force-pushed update-structs from 9747aff8b8 to 62bf840fae 2021-02-13 05:33:34 +00:00 Compare
6543 added 1 commit 2021-02-13 05:40:16 +00:00
Add migration hints for breaking change
Some checks failed
continuous-integration/drone/pr Build is failing
Details
7417c4b8e2
6543 added 1 commit 2021-02-13 16:14:43 +00:00
Merge branch 'master' into update-structs
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f73d506d8b
6543 added 1 commit 2021-02-13 16:19:02 +00:00
impruve docs
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fb8a671da2
lunny approved these changes 2021-02-13 16:29:27 +00:00
Dismissed
zeripath reviewed 2021-02-13 16:37:43 +00:00
Dismissed
docs/migrate-v0.13-to-v0.14.md Outdated
@ -27,1 +28,4 @@
- [#467 Remove & Rename TrackedTimes list functions](https://gitea.com/gitea/go-sdk/pulls/467)
## Some Fields of Structs got optional
zeripath commented 2021-02-13 16:37:43 +00:00
Owner
Copy Link

New Optional Fields

New Optional Fields
6543 marked this conversation as resolved
zeripath reviewed 2021-02-13 16:39:17 +00:00
Dismissed
docs/migrate-v0.13-to-v0.14.md Outdated
@ -28,0 +33,4 @@
The EditUserOption struct is only affected currently.
For example Email type changed from `string` to `*string`.
The easyest migration path is, to war your options with:
zeripath commented 2021-02-13 16:39:17 +00:00
Owner
Copy Link

s/easyest/easiest

I don't understand to war your options with?

s/easyest/easiest I don't understand `to war your options with`?
6543 marked this conversation as resolved
zeripath reviewed 2021-02-13 16:41:14 +00:00
Dismissed
gitea/repo_migrate.go Outdated
@ -80,1 +79,4 @@
}
case GitServiceGogs:
if len(opt.AuthToken) == 0 {
return fmt.Errorf("gogs require token authentication")
zeripath commented 2021-02-13 16:41:14 +00:00
Owner
Copy Link

gogs requires token authentication

gogs require**s** token authentication
6543 marked this conversation as resolved
6543 added 1 commit 2021-02-13 16:46:24 +00:00
X requires token authentication
All checks were successful
continuous-integration/drone/pr Build is passing
Details
72914776ae
6543 added 1 commit 2021-02-13 16:52:42 +00:00
New Optional Fields
All checks were successful
continuous-integration/drone/pr Build is passing
Details
578a56b7eb
zeripath reviewed 2021-02-13 17:47:24 +00:00
Dismissed
docs/migrate-v0.13-to-v0.14.md Outdated
@ -28,0 +30,4 @@
## New Optional Fields
`EditUserOption` struct is has gained several new Optional fields.
zeripath commented 2021-02-13 17:47:24 +00:00
Owner
Copy Link

The EditUserOption struct has gained several new Optional fields.

The `EditUserOption` struct has gained several new Optional fields.
6543 marked this conversation as resolved
6543 added 1 commit 2021-02-13 18:54:56 +00:00
next
Some checks failed
continuous-integration/drone/pr Build is failing
Details
2d5e3f4a51
zeripath approved these changes 2021-02-13 18:57:08 +00:00
Dismissed
zeripath left a comment
Owner
Copy Link

Apart from the double period at the end of the line. LGTM.

Apart from the double period at the end of the line. LGTM.
docs/migrate-v0.13-to-v0.14.md Outdated
@ -28,0 +30,4 @@
## New Optional Fields
The `EditUserOption` struct has gained several new Optional fields..
zeripath commented 2021-02-13 18:56:47 +00:00
Owner
Copy Link

oops double terminal period here

oops double terminal period here
6543 marked this conversation as resolved
6543 added 1 commit 2021-02-13 19:00:02 +00:00
next-try
All checks were successful
continuous-integration/drone/pr Build is passing
Details
48ff1a903a
6543 merged commit 8947cd3b00 into master 2021-02-13 19:24:00 +00:00
6543 referenced this issue from a commit 2021-02-13 19:24:00 +00:00
Update Structs (#486)
6543 deleted branch update-structs 2021-02-13 19:24:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.14.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#486
No description provided.
Delete Branch "6543/go-sdk:update-structs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?