refactor: more descriptive errors when validating repo metadata #567

takirala · 2022-01-22T00:09:12Z

takirala commented

2022-01-22 00:09:12 +00:00

When creating a repository using gitea client, it performs some validation on client options and the errors returned are not descriptive enough. This PR makes the errors more precise so that the user can fix the errors easily.

takirala added 1 commit 2022-01-22 00:09:12 +00:00

refactor: more descriptive errors when validation repo metadata

Signed-off-by: takirala <takirala@noreply.gitea.io>

continuous-integration/drone/pr Build is failing

Details

1474c58230

lunny approved these changes 2022-01-22 03:57:50 +00:00

noerw approved these changes 2022-01-31 17:49:00 +00:00

takirala commented

2022-01-31 18:51:34 +00:00

Ci is failing with

	cd gitea && go build
93s
42	+ curl --noproxy "*" http://gitea:3000/api/v1/version
95s
43	  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
95s
44	                                 Dload  Upload   Total   Spent    Left  Speed
95s
45	
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: gitea

The diff of this PR looks innocent enough to make me think i have not caused this error (:
Assuming this is a flake - can someone help me rerun this ?!

Ci is failing with ``` cd gitea && go build 93s 42 + curl --noproxy "*" http://gitea:3000/api/v1/version 95s 43 % Total % Received % Xferd Average Speed Time Time Time Current 95s 44 Dload Upload Total Spent Left Speed 95s 45 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: gitea ``` The diff of this PR looks innocent enough to make me think i have not caused this error (: Assuming this is a flake - can someone help me rerun this ?!

takirala changed title from ~~refactor: more descriptive errors when validation repo metadata~~ to refactor: more descriptive errors when validating repo metadata

2022-01-31 19:18:00 +00:00

6543 approved these changes 2022-01-31 23:14:29 +00:00

6543 merged commit 73182f46eb into master

2022-01-31 23:14:46 +00:00

6543 referenced this issue from a commit

2022-01-31 23:14:46 +00:00

More descriptive errors when validating repo metadata (#567)

6543 added the

kind/bug

label 2022-01-31 23:14:53 +00:00

6543 added this to the v0.16.0 milestone 2022-01-31 23:15:02 +00:00

6543 commented

2022-01-31 23:15:37 +00:00

the issue is not comming from you - force merged - but have to fix it yes :/

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#567