Return error message for 4xx errors #583

jolheiser · 2022-04-26T20:00:37Z

jolheiser commented

2022-04-26 20:00:37 +00:00

Resolves #582
Resolves #551

As noted in both issues, we could put the resp.Body back, however I think this should also suffice, as it will return error messages when appropriate based on the JSON response.

Resolves #582 Resolves #551 As noted in both issues, we _could_ put the `resp.Body` back, however I think this should also suffice, as it will return error messages when appropriate based on the JSON response.

❤️ 1

jolheiser added 1 commit 2022-04-26 20:00:38 +00:00

Return error message for 4xx errors

Signed-off-by: jolheiser <john.olheiser@gmail.com>

continuous-integration/drone/pr Build is passing

Details

1aa092e608

lunny approved these changes 2022-04-27 03:08:12 +00:00

6543 approved these changes 2022-04-28 02:56:24 +00:00

6543 merged commit 89a4b0be6e into master

2022-04-28 02:56:33 +00:00

6543 referenced this issue from a commit

2022-04-28 02:56:34 +00:00

Return error message for 4xx errors (#583)

jolheiser deleted branch resp-err

2022-04-29 16:06:39 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#583