gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Add DeleteIssue() #598

Merged
6543 merged 5 commits from earl-warren/go-sdk:wip-issue-delete into main 2022-09-15 21:45:01 +00:00
Conversation 13 Commits 5 Files Changed 2 +27 -2
earl-warren commented 2022-08-21 23:46:26 +00:00
Contributor
Copy Link

Fixes: #596

Signed-off-by: Earl Warren contact@earl-warren.org

Fixes: #596 Signed-off-by: Earl Warren <contact@earl-warren.org>
earl-warren added 1 commit 2022-08-21 23:46:51 +00:00
add issue delete 
Fixes: #596

Signed-off-by: Earl Warren <contact@earl-warren.org>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
49e74ff9d3
earl-warren commented 2022-08-22 00:09:28 +00:00
Author
Contributor
Copy Link

duplicate of #597 because of this Gitea bug

duplicate of #597 because of [this Gitea bug](https://github.com/go-gitea/gitea/issues/20906)
earl-warren commented 2022-08-22 00:11:44 +00:00
Author
Contributor
Copy Link

The CI failure is unrelated (see #599)

The CI failure is unrelated (see https://gitea.com/gitea/go-sdk/issues/599)
earl-warren commented 2022-09-04 06:29:59 +00:00
Author
Contributor
Copy Link

Ping for review in the dev chatroom:

I proposed a patch to go-sdk to add the new DeleteIssue API endpoint, would someone be so kind as to review it? #598 . The CI does not pass but it is unrelated.

Ping for review in [the dev chatroom](https://matrix.to/#/!ZPKKzkRLwGDVwcTJtv:matrix.org/$MbfDdLHj0iPTID7FWL_H_NgQ6eAtjL5VXXfCNWzfask?via=libera.chat&via=t2bot.io&via=matrix.org): I proposed a patch to go-sdk to add the new DeleteIssue API endpoint, would someone be so kind as to review it? https://gitea.com/gitea/go-sdk/pulls/598 . The CI does not pass but [it is unrelated](https://gitea.com/gitea/go-sdk/issues/599).
6543 commented 2022-09-04 13:47:30 +00:00
Owner
Copy Link

@earl-warren can you allow maintainer to edit this pull?

@earl-warren can you allow maintainer to edit this pull?
zeripath added 1 commit 2022-09-04 16:38:55 +00:00
Merge branch 'main' into wip-issue-delete
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8340e49ab4
zeripath commented 2022-09-04 16:40:08 +00:00
Owner
Copy Link

@6543 I've pushed the update button using the magical powers at my disposal.

@6543 I've pushed the update button using the magical powers at my disposal.
👍 1
zeripath approved these changes 2022-09-04 16:40:30 +00:00
earl-warren commented 2022-09-04 21:58:15 +00:00
Author
Contributor
Copy Link

@6543 done

@6543 done
6543 commented 2022-09-06 20:16:37 +00:00
Owner
Copy Link

Thanks, I'm this week traveling so cant say when i have time to look into it again

Thanks, I'm this week traveling so cant say when i have time to look into it again
earl-warren commented 2022-09-15 09:57:20 +00:00
Author
Contributor
Copy Link

Is there anything I can do to move this PR forward?

Is there anything I can do to [move this PR forward](https://matrix.to/#/!ZPKKzkRLwGDVwcTJtv:matrix.org/$BL_0rGoL0lmdwL5SKREfYzS91OyaQjoLxpDUIvEhYiU?via=libera.chat&via=t2bot.io&via=matrix.org)?
earl-warren added 1 commit 2022-09-15 10:03:45 +00:00
Merge branch 'main' into wip-issue-delete
Some checks failed
continuous-integration/drone/pr Build is failing
Details
4ce460f0fb
noerw approved these changes 2022-09-15 11:11:26 +00:00
noerw commented 2022-09-15 11:12:36 +00:00
Member
Copy Link

@earl-warren thanks for the ping, it was just lacking another review.
I'll merge this despite unrelated CI failure and send a PR to fix CI in this repo.
Ah, I can't merge ? We'll have to fix CI anyway, once thats done, just merge main once more.

@earl-warren thanks for the ping, it was just lacking another review. ~~I'll merge this despite unrelated CI failure and send a PR to fix CI in this repo.~~ Ah, I can't merge ? We'll have to fix CI anyway, once thats done, just merge main once more.
👍 1
noerw changed title from add issue delete to Add `DeleteIssue()` 2022-09-15 11:13:13 +00:00
noerw scheduled this pull request to auto merge when all checks succeed 2022-09-15 11:13:23 +00:00
noerw added the
kind/feature
 label 2022-09-15 11:32:20 +00:00
noerw added this to the v0.16.0 milestone 2022-09-15 11:34:42 +00:00
earl-warren commented 2022-09-15 11:40:41 +00:00
Author
Contributor
Copy Link

@noerw thanks for the review!

@noerw thanks for the review!
6543 commented 2022-09-15 17:33:50 +00:00
Owner
Copy Link

well I had some local fixes for the CI but your tests did fail, the code looks good and manually testing the api works too, so no idea what's going on

that's why i did not put my lgtm here

let me fix the CI first and thenn I'll update this pull ontop of it

well I had some local fixes for the CI but your tests did fail, the code looks good and manually testing the api works too, so no idea what's going on that's why i did not put my lgtm here let me fix the CI first and thenn I'll update this pull ontop of it
6543 referenced this issue from a commit 2022-09-15 17:47:17 +00:00
Fix broken CI (#602)
6543 added 1 commit 2022-09-15 18:26:47 +00:00
Merge branch 'main' into wip-issue-delete
Some checks are pending
continuous-integration/drone/pr Build is running
Details
c313645517
6543 commented 2022-09-15 18:36:15 +00:00
Owner
Copy Link
--- FAIL: TestIssue (2.32s)
    issue_test.go:60: 
        	Error Trace:	issue_test.go:60
        	            				issue_test.go:25
        	Error:      	Received unexpected error:
        	            	The target couldn't be found.
        	Test:       	TestIssue

It's related

``` --- FAIL: TestIssue (2.32s) issue_test.go:60: Error Trace: issue_test.go:60 issue_test.go:25 Error: Received unexpected error: The target couldn't be found. Test: TestIssue ``` It's related
earl-warren added 1 commit 2022-09-15 19:11:36 +00:00
the test deleting the issue must use the Index not the ID
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8e680748d6
earl-warren commented 2022-09-15 19:25:37 +00:00
Author
Contributor
Copy Link
--- FAIL: TestIssue (2.32s)
    issue_test.go:60: 
        	Error Trace:	issue_test.go:60
        	            				issue_test.go:25
        	Error:      	Received unexpected error:
        	            	The target couldn't be found.
        	Test:       	TestIssue

It's related

Fixed. Now there is another error that does not appear to be related because it also fails on the main branch. See gitea/go-sdk#605

2022/09/15 19:22:03 == TestTeamSearch ==

--- FAIL: TestTeamSearch (0.31s)

org_team_test.go:53: 

    	Error Trace:	org_team_test.go:53

    	Error:      	"[]" should have 1 item(s), but has 0

    	Test:       	TestTeamSearch
> ``` > --- FAIL: TestIssue (2.32s) > issue_test.go:60: > Error Trace: issue_test.go:60 > issue_test.go:25 > Error: Received unexpected error: > The target couldn't be found. > Test: TestIssue > ``` > > It's related Fixed. Now there is another error that does not appear to be related because it also fails on the main branch. See gitea/go-sdk#605 > 2022/09/15 19:22:03 == TestTeamSearch == > > --- FAIL: TestTeamSearch (0.31s) > > org_team_test.go:53: > > Error Trace: org_team_test.go:53 > > Error: "[]" should have 1 item(s), but has 0 > > Test: TestTeamSearch
6543 approved these changes 2022-09-15 21:44:07 +00:00
6543 merged commit aef4e5e2bd into main 2022-09-15 21:45:01 +00:00
6543 referenced this issue from a commit 2022-09-15 21:45:01 +00:00
Add `DeleteIssue()` (#598)
Sign in to join this conversation.
Reviewers
No reviewers
zeripath
noerw
6543
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.16.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#598
No description provided.
Delete Branch "earl-warren/go-sdk:wip-issue-delete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?