gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

add func to DownloadReleaseAttachment #609

Closed
edieruby wants to merge 7 commits from edieruby/go-sdk:download.attachment into main
pull from: edieruby/go-sdk:download.attachment
merge into: gitea:main
Conversation 8 Commits 7 Files Changed 2 +46 -11
edieruby commented 2022-10-11 06:09:26 +00:00
Contributor
Copy Link
No description provided.
edieruby added 1 commit 2022-10-11 06:09:27 +00:00
add func to DownloadReleaseAttachment
Some checks failed
continuous-integration/drone/pr Build is failing
Details
a94443711e
edieruby added 1 commit 2022-10-11 06:37:01 +00:00
add comment
All checks were successful
continuous-integration/drone/pr Build is passing
Details
424487f641
lunny reviewed 2022-10-13 10:58:41 +00:00
gitea/attachment.go Outdated
@ -111,1 +111,4 @@
}
// DownloadReleaseAttachment Download an Attachment of the Release by UUID
func (c *Client) DownloadReleaseAttachment(UUID string) ([]byte, *Response, error) {
lunny commented 2022-10-13 10:58:41 +00:00
Owner
Copy Link

A io.Reader return parameter maybe better?

A `io.Reader` return parameter maybe better?
edieruby commented 2022-10-13 12:14:01 +00:00
Author
Contributor
Copy Link

I will update it.

I will update it.
6543 marked this conversation as resolved
edieruby added 1 commit 2022-10-14 01:39:29 +00:00
change to io.ReadCloser
All checks were successful
continuous-integration/drone/pr Build is passing
Details
592eb3d33f
6543 commented 2022-10-16 18:35:53 +00:00
Owner
Copy Link

@edieruby please allow "maintainers edit" on pulls :)

@edieruby please allow "maintainers edit" on pulls :)
edieruby commented 2022-10-17 01:14:26 +00:00
Author
Contributor
Copy Link

@edieruby please allow "maintainers edit" on pulls :)

allowed

> @edieruby please allow "maintainers edit" on pulls :) allowed
6543 added 1 commit 2022-10-19 15:15:16 +00:00
Merge branch 'main' into download.attachment
Some checks failed
continuous-integration/drone/pr Build is failing
Details
eb0e6c07f9
6543 reviewed 2022-10-19 15:18:28 +00:00
gitea/client.go Outdated
@ -396,6 +450,21 @@ func (c *Client) getStatusCode(method, path string, header http.Header, body io.
return resp.StatusCode, resp, nil
}
func (c *Client) getRawResponse(method, path string, header http.Header, body io.Reader) (io.ReadCloser, *Response, error) {
6543 commented 2022-10-19 15:18:28 +00:00
Owner
Copy Link

ther exist a getResponseReader already

ther exist a `getResponseReader` already
6543 marked this conversation as resolved
6543 reviewed 2022-10-19 15:19:13 +00:00
gitea/client.go
@ -303,6 +303,60 @@ func (c *Client) doRequest(method, path string, header http.Header, body io.Read
return &Response{resp}, nil
}
func (c *Client) doRawRequest(method, path string, header http.Header, body io.Reader) (*Response, error) {
6543 commented 2022-10-19 15:19:12 +00:00
Owner
Copy Link

why we need this?

why we need this?
6543 commented 2022-10-19 15:24:01 +00:00
Owner
Copy Link

ah you do use the web url ... as there is no api equivalent

in this case we have to refactor getWebResponse()

ah you do use the web url ... as there is no api equivalent in this case we have to refactor getWebResponse()
edieruby commented 2022-10-20 02:17:30 +00:00
Author
Contributor
Copy Link

Used this func at the beginning.
Seems not work.
lack header setting.
different from this func.
func (c *Client) doRequest(method, path string, header http.Header, body io.Reader) (*Response, error)

Used this func at the beginning. Seems not work. lack header setting. different from this func. func (c *Client) doRequest(method, path string, header http.Header, body io.Reader) (*Response, error)
6543 marked this conversation as resolved
6543 commented 2022-10-19 15:43:19 +00:00
Owner
Copy Link

edieruby/go-sdk#1

https://gitea.com/edieruby/go-sdk/pulls/1
6543 commented 2022-10-19 15:43:57 +00:00
Owner
Copy Link

also it would be nice to have a test in place :)

also it would be nice to have a test in place :)
edieruby closed this pull request 2022-10-20 01:56:11 +00:00
edieruby reopened this pull request 2022-10-20 01:56:16 +00:00
edieruby commented 2022-10-20 02:02:51 +00:00
Author
Contributor
Copy Link

also it would be nice to have a test in place :)

Hello, I used the current func at the beginning.
It does not work.
I tested it with my local gitea.
I get the response is 404 Not Found.

It seems that this API works with auth.
gitea/client.go:224 func (c *Client) doWebRequest(method, path string, body io.Reader) (*Response, error)
This func is lack of req.Header.Set("Authorization", "token "+c.accessToken)
or req.SetBasicAuth(c.username, c.password)

> also it would be nice to have a test in place :) Hello, I used the current func at the beginning. It does not work. I tested it with my local gitea. I get the response is 404 Not Found. It seems that this API works with auth. gitea/client.go:224 func (c *Client) doWebRequest(method, path string, body io.Reader) (*Response, error) This func is lack of req.Header.Set("Authorization", "token "+c.accessToken) or req.SetBasicAuth(c.username, c.password)
6543 commented 2022-11-02 19:28:47 +00:00
Owner
Copy Link

well atm it only works on public repos ...
as there is no api for it it looks like

well atm it only works on public repos ... as there is no api for it it looks like
6543 commented 2022-11-02 19:29:38 +00:00
Owner
Copy Link

test this func against public attachments!

for private once we have to either add some roules to the web routes or else add a api dedicated download api

test this func against public attachments! for private once we have to either add some roules to the web routes or else add a api dedicated download api
edieruby added 2 commits 2022-11-03 01:43:52 +00:00
edieruby commented 2022-11-03 01:50:33 +00:00
Author
Contributor
Copy Link

Download the attachment in public repo is okay.

My original purpose is download the attachment in private repo.

The gitea was deployed in my local environment, and most repos are private.

Download the attachment in public repo is okay. My original purpose is download the attachment in private repo. The gitea was deployed in my local environment, and most repos are private.
👍 1 😆 1
6543 reviewed 2022-11-12 00:22:49 +00:00
gitea/attachment.go
@ -112,0 +112,4 @@
// DownloadReleaseAttachment Download an Attachment of the Release by UUID
func (c *Client) DownloadReleaseAttachment(UUID string) (io.ReadCloser, *Response, error) {
if err := escapeValidatePathSegments(&UUID); err != nil {
6543 commented 2022-11-12 00:22:49 +00:00
Owner
Copy Link

asap there is an official api ... we could add this here instead and use the old method only as fallback

asap there is an official api ... we could add this here instead and use the old method only as fallback
6543 marked this conversation as resolved
6543 reviewed 2022-11-12 00:24:49 +00:00
gitea/client.go Outdated
@ -232,21 +232,42 @@ func (c *Client) getWebResponse(method, path string, body io.Reader) ([]byte, *R
client := c.client // client ref can change from this point on so safe it
6543 commented 2022-11-12 00:24:49 +00:00
Owner
Copy Link

L230 error need to be checked

L230 error need to be checked
edieruby commented 2022-11-22 01:45:58 +00:00
Author
Contributor
Copy Link

add the check

add the check
edieruby added 1 commit 2022-11-14 02:02:56 +00:00
add the error check
All checks were successful
continuous-integration/drone/pr Build is passing
Details
19e129e36b
lunny reviewed 2022-11-22 02:51:03 +00:00
gitea/client.go
@ -248,0 +255,4 @@
// check for errors
data, err := statusCodeToErr(resp)
if err != nil {
return io.NopCloser(bytes.NewReader(data)), resp, err
lunny commented 2022-11-22 02:51:03 +00:00
Owner
Copy Link

if err != nil, will data be still kept correct content?

if err != nil, will `data` be still kept correct content?
edieruby commented 2022-11-22 09:52:15 +00:00
Author
Contributor
Copy Link

Data will contain the error message.
It's just same with the process in getResponseReader Line:380

Data will contain the error message. It's just same with the process in getResponseReader Line:380
edieruby closed this pull request 2023-12-28 07:35:08 +00:00
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
testing / testing*
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#609
No description provided.
Delete Branch "edieruby/go-sdk:download.attachment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?