existingClaim at persistence has got problems with namespace variable in the name #203

New Issue

skriesch · 2021-07-07T12:25:25Z

skriesch commented

2021-07-07 12:25:25 +00:00

We are using the gitea helm-chart with Jenkins deployments.
Therefore, we identify PVCs additionally with the namespace name/variable:

persistence:
## Enable persistence using Persistent Volume Claims
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
  enabled: true
  existingClaim: gitea-gitea-**{{.Release.Namespace}}**
  size: 10Gi
  storageClass: gitea-manual
  accessModes:
    - ReadWriteOnce
  labels: {}
  annotations: 
    "helm.sh/resource-policy": keep
volumePermissions:
  enabled: true

That will be accepted by the PostgreSQL sub-helm-chart, but not by the gitea helm-chart.

We are using the solution of the PostgreSQL helm-chart in the gitea helm-chart now.

Before in templates/gitea/statefulset.yaml:
line 171: claimName: {{ .Values.persistence.existingClaim }}

Solution:

{{- with .Values.persistence.existingClaim }}
            claimName: {{ tpl . $ }}
{{- end }}

We are using the gitea helm-chart with Jenkins deployments. Therefore, we identify PVCs additionally with the namespace name/variable: ``` persistence: ## Enable persistence using Persistent Volume Claims ## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/ enabled: true existingClaim: gitea-gitea-**{{.Release.Namespace}}** size: 10Gi storageClass: gitea-manual accessModes: - ReadWriteOnce labels: {} annotations: "helm.sh/resource-policy": keep volumePermissions: enabled: true ``` That will be accepted by the PostgreSQL sub-helm-chart, but not by the gitea helm-chart. We are using the solution of the PostgreSQL helm-chart in the gitea helm-chart now. Before in templates/gitea/statefulset.yaml: line 171: `claimName: {{ .Values.persistence.existingClaim }}` Solution: ``` {{- with .Values.persistence.existingClaim }} claimName: {{ tpl . $ }} {{- end }} ```

justusbunsi commented

2021-07-07 14:13:47 +00:00

If you like, you can open a PR for these changes. They are always welcome and appreciated. ?

👍 1

skriesch referenced this issue

2021-07-07 14:33:22 +00:00

Fix for #203 possible existingClaim at persistence with namespace variable in the name #204

skriesch commented

2021-07-07 14:34:46 +00:00

PR is available. :)

👍 1

justusbunsi added the