gitea/helm-chart
45
54
Fork 128
Code Issues 31 Pull Requests 7 Actions Releases 87 Activity

Refactor bash scripting for init.yaml #246

New Issue
Closed
opened 2021-11-16 16:48:06 +00:00 by nwmcsween · 7 comments
nwmcsween commented 2021-11-16 16:48:06 +00:00
Copy Link

Non standard sh isn't really needed from what I can see in init.yaml

Non standard sh isn't really needed from what I can see in init.yaml
justusbunsi commented 2021-11-16 17:02:27 +00:00
Member
Copy Link

Could you explain a bit more detailed what you mean?

Could you explain a bit more detailed what you mean?
nwmcsween commented 2021-11-16 17:18:26 +00:00
Author
Copy Link

The scripts in https://gitea.com/gitea/helm-chart/src/branch/master/templates/gitea/init.yaml don't require any bashisms and could be refactored to standard sh #!/bin/sh

The scripts in https://gitea.com/gitea/helm-chart/src/branch/master/templates/gitea/init.yaml don't require any bashisms and could be refactored to standard sh `#!/bin/sh`
justusbunsi commented 2021-11-16 17:22:15 +00:00
Member
Copy Link

I get what you mean. If you like, you can create a PR to change this. Any contribution is welcome.

I get what you mean. If you like, you can create a PR to change this. Any contribution is welcome.
justusbunsi added the
kind
refactor
 label 2021-11-16 17:23:16 +00:00
pat-s commented 2022-03-05 16:14:49 +00:00
Member
Copy Link

I wonder though if this change will make it harder to contribute in the future.
Most people possibly write in bash and not in sh and if there's a strong limitation to use sh only, people might eventually refrain from contributing?

I wonder though if this change will make it harder to contribute in the future. Most people possibly write in `bash` and not in `sh` and if there's a strong limitation to use `sh` only, people might eventually refrain from contributing?
nwmcsween commented 2022-03-18 19:42:06 +00:00
Author
Copy Link

I wonder though if this change will make it harder to contribute in the future.
Most people possibly write in bash and not in sh and if there's a strong limitation to use sh only, people might eventually refrain from contributing?

I don't see why? Bash isn't ubiquitous, take for example using any Alpine Linux images. There is no real limitation of Bash vs POSIX shell besides Bash making some things easier. Also the pervalnce of using #!/bin/bash needs to stop as a lot of the time it's just cargo culted.

> I wonder though if this change will make it harder to contribute in the future. > Most people possibly write in `bash` and not in `sh` and if there's a strong limitation to use `sh` only, people might eventually refrain from contributing? I don't see why? Bash isn't ubiquitous, take for example using any Alpine Linux images. There is no real limitation of Bash vs POSIX shell besides Bash making some things easier. Also the pervalnce of using `#!/bin/bash` needs to stop as a lot of the time it's just cargo culted.
justusbunsi commented 2022-03-20 10:16:17 +00:00
Member
Copy Link

Please see my comment on PR 273. (#273 (comment))

Please see my comment on PR 273. (https://gitea.com/gitea/helm-chart/pulls/273#issuecomment-694188)
justusbunsi commented 2023-09-05 19:33:58 +00:00
Member
Copy Link

Closing for now. Feel free to reopen.

Closing for now. Feel free to reopen.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#246
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?