Gitea configuration values containing spaces breaks the init-app-ini initContainer #260

New Issue

nmasse-itix · 2021-12-09T10:24:56Z

nmasse-itix commented

2021-12-09 10:24:56 +00:00

Hello,

I'm using this helm chart to deploy a Gitea instance with the following configuration.

gitea:
  config:
    cron.update_mirrors:
      SCHEDULE: "@every 24h"

The gitea "init-app-ini" initContainer fails with the following error:

bash: export: `24h': not a valid identifier

The error can be fixed by enclosing the value in single quotes in templates/gitea/config.yaml:

- export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $n_key | upper }}={{ $n_value }}
+ export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $n_key | upper }}='{{ $n_value }}'

[...]

-export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $key | upper }}={{ $value }}
+export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $key | upper }}='{{ $value }}'

Hello, I'm using this helm chart to deploy a Gitea instance with the following configuration. ```yaml gitea: config: cron.update_mirrors: SCHEDULE: "@every 24h" ``` The gitea "init-app-ini" initContainer fails with the following error: ``` bash: export: `24h': not a valid identifier ``` The error can be fixed by enclosing the value in single quotes in templates/gitea/config.yaml: ```diff - export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $n_key | upper }}={{ $n_value }} + export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $n_key | upper }}='{{ $n_value }}' [...] -export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $key | upper }}={{ $value }} +export ENV_TO_INI__{{ $key | upper | replace "." "_0X2E_" | replace "-" "_0X2D_" }}__{{ $key | upper }}='{{ $value }}' ```

nmasse-itix referenced this issue

2021-12-09 10:34:16 +00:00

Handle gitea config values containing spaces #261

justusbunsi added the

kind

bug

label 2021-12-18 18:00:52 +00:00

justusbunsi referenced a pull request that will close this issue

2021-12-20 11:47:15 +00:00

Generic way for configuring Gitea app.ini #240

luhahn closed this issue

2021-12-22 10:44:06 +00:00