gitea/helm-chart
45
54
Fork 127
Code Issues 31 Pull Requests 7 Actions Releases 87 Activity

Make test pods optional and allow image override #360

Merged
justusbunsi merged 6 commits from ooms97/helm-chart:main into main 2023-03-09 15:25:45 +00:00
Conversation 1 Commits 6 Files Changed 3 +17 -4
ooms97 commented 2022-09-13 18:42:33 +00:00
Contributor
Copy Link

Description of the change

Make the test-connection Pod optional and override the wget container's image.

Benefits

Allows users to enable/disabled the test-connection Pod and override the wget container's image.

Possible drawbacks

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change Make the test-connection Pod optional and override the wget container's image. ### Benefits Allows users to enable/disabled the test-connection Pod and override the wget container's image. ### Possible drawbacks <!-- Describe any known limitations with your change --> ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md`
ooms97 added 1 commit 2022-09-13 18:42:33 +00:00
Make test pods optional and allow image override (#1) 
Co-authored-by: umer <umer.anwar@nuance.com>
Reviewed-on: ooms97/helm-chart#1
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5fbe70050f
ooms97 changed title from Make test pods optional and allow image override (#1) to Make test pods optional and allow image override 2022-09-13 18:42:40 +00:00
justusbunsi reviewed 2022-09-25 13:10:41 +00:00
values.yaml Outdated
@ -473,2 +473,4 @@
## @param checkDeprecation Set it to false to skip this basic validation check.
checkDeprecation: true
## @section Test
justusbunsi commented 2022-09-25 13:07:45 +00:00
Member
Copy Link

A separate section is not necessary, IMO. Modifying the helm tests can be considered "advanced". ?

A separate section is not necessary, IMO. Modifying the helm tests can be considered "advanced". ?
👍 1
ooms97 commented 2022-10-07 22:10:27 +00:00
Author
Contributor
Copy Link

Great point, changes have been added! ?

Great point, changes have been added! ?
ooms97 marked this conversation as resolved
ooms97 added 2 commits 2022-10-07 22:09:40 +00:00
Merge pull request 'move test to Advanced section' (#2) from changes into main 
Reviewed-on: ooms97/helm-chart#2
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cd11c3d882
ooms97 added 1 commit 2022-10-07 22:09:53 +00:00
Merge branch 'main' into main
All checks were successful
continuous-integration/drone/pr Build is passing
Details
3fdbf12fc2
pat-s reviewed 2022-12-27 09:28:01 +00:00
templates/tests/test-http-connection.yaml
@ -10,3 +11,3 @@
containers:
- name: wget
image: busybox
image: {{ .Values.test.image | default "busybox" }}
pat-s commented 2022-12-27 09:28:01 +00:00
Member
Copy Link

Should we split this in image.name and image.tag to follow canonical conventions?

Should we split this in `image.name` and `image.tag` to follow canonical conventions?
ooms97 marked this conversation as resolved
justusbunsi added the
kind
feature
 label 2023-01-14 12:54:51 +00:00
ooms97 added 2 commits 2023-02-02 21:03:41 +00:00
Add image name and image tag
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce6b25bad0
pat-s approved these changes 2023-03-09 09:09:16 +00:00
pat-s left a comment
Member
Copy Link

LGTM

LGTM
pat-s commented 2023-03-09 09:09:38 +00:00
Member
Copy Link

@justusbunsi Should we get that in if LGTM to you?

@justusbunsi Should we get that in if LGTM to you?
justusbunsi approved these changes 2023-03-09 15:25:00 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM. Thanks for your contribution.

LGTM. Thanks for your contribution.
justusbunsi merged commit 9a6cb4d357 into main 2023-03-09 15:25:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
justusbunsi
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#360
No description provided.
Delete Branch "ooms97/helm-chart:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?