Lock readme-generator-for-helm dependency #369

justusbunsi · 2022-10-13T04:45:15Z

justusbunsi commented

2022-10-13 04:45:15 +00:00

With every push on main/master branch of that repository, the referenced
tarball is replaced, causing npm integrity checks to fail. Locking the used
reference to a specific commit hash is more reliable.

There is an open issue regarding publishing on NPM. As long as this is
not resolved, we would need to use this workaround to get updates.

(https://github.com/bitnami-labs/readme-generator-for-helm/issues/36)

Signed-off-by: justusbunsi sk.bunsenbrenner@gmail.com

With every push on main/master branch of that repository, the referenced tarball is replaced, causing npm integrity checks to fail. Locking the used reference to a specific commit hash is more reliable. There is an open issue regarding publishing on NPM. As long as this is not resolved, we would need to use this workaround to get updates. (https://github.com/bitnami-labs/readme-generator-for-helm/issues/36) Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>

justusbunsi added 1 commit 2022-10-13 04:45:15 +00:00

Lock readme-generator-for-helm dependency

With every push on main/master branch of that repository, the referenced
tarball is replaced, causing integrity checks to fail. Locking the used
reference to a specific commit hash is more reliable.

There is an open issue regarding publishing on NPM. As long as this is
not resolved, we would need to use this workaround to get updates.

(https://github.com/bitnami-labs/readme-generator-for-helm/issues/36)

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>

continuous-integration/drone/pr Build is passing

Details

2d09cbc3af

justusbunsi requested review from Maintainers 2022-10-13 04:48:00 +00:00

pat-s approved these changes 2022-10-13 07:45:43 +00:00

pat-s left a comment

Cheap workaround for the moment ?
How do we make sure to not forget about the fixed hash?

Should we look for other README generators?

Cheap workaround for the moment ? How do we make sure to not forget about the fixed hash? Should we look for other README generators?

techknowlogick approved these changes 2022-10-13 16:16:33 +00:00

techknowlogick merged commit d1f5dca573 into main

2022-10-13 16:16:41 +00:00