gitea/helm-chart
45
54
Fork 126
Code Issues 32 Pull Requests 8 Actions Releases 87 Activity

Temporary revert GPG feature for semver based retagging #373

Merged
justusbunsi merged 2 commits from justusbunsi/helm-chart:temporary-remove-gpg-feature into main 2022-10-20 16:35:20 +00:00
Conversation 1 Commits 2 Files Changed 18 +22 -440
justusbunsi commented 2022-10-20 16:18:57 +00:00
Member
Copy Link

Feature #343 happens to be a breaking change when enabling .Values.signing but not specifying
any of the new private key properties. Tag v6.0.2 is therefore not following semantic versioning.

This temporarily reverts commit b8f0310c43 and a fix-up commit 57a1cd27d9
to retag 6.0.2 as 6.0.3.

Feature #343 happens to be a breaking change when enabling `.Values.signing` but not specifying any of the new private key properties. Tag `v6.0.2` is therefore not following semantic versioning. This temporarily reverts commit b8f0310c43bd71dd48ac92b70d8ebdb94d43c29b and a fix-up commit 57a1cd27d9a6cc014f425fabeadb0db34f242b0e to retag 6.0.2 as 6.0.3.
❤️ 1
justusbunsi added 2 commits 2022-10-20 16:18:58 +00:00
Revert "Add gpg configuration settings (#343)" 
This reverts commit b8f0310c43.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
11026a985b
justusbunsi requested review from techknowlogick 2022-10-20 16:19:29 +00:00
justusbunsi requested review from luhahn 2022-10-20 16:19:29 +00:00
justusbunsi requested review from pat-s 2022-10-20 16:19:30 +00:00
techknowlogick approved these changes 2022-10-20 16:24:15 +00:00
luhahn approved these changes 2022-10-20 16:33:15 +00:00
luhahn left a comment
Member
Copy Link

lgtm

lgtm
justusbunsi merged commit d5ce1a47ea into main 2022-10-20 16:35:20 +00:00
justusbunsi deleted branch temporary-remove-gpg-feature 2022-10-20 16:35:20 +00:00
viceice commented 2022-10-21 06:27:26 +00:00
Contributor
Copy Link

thankyou ❤️

thankyou :heart:
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
techknowlogick
luhahn
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#373
No description provided.
Delete Branch "justusbunsi/helm-chart:temporary-remove-gpg-feature"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?