Usage advice: quote app.ini section headers in values.yml if they contain a dot #516

New Issue

pat-s · 2023-09-22T15:30:26Z

pat-s commented

2023-09-22 15:30:26 +00:00

See discussion at https://github.com/go-gitea/gitea/issues/26838.

All section headers in values.yml under gitea.config that contain a dot should be written as

"section.header":
  key1: value1

Without the quotes, helm will split the section name into two parts consistent of "section" and "header" whereas they should appear "as is" in app.ini, i.e. "section.header".

See discussion at https://github.com/go-gitea/gitea/issues/26838. All section headers in `values.yml` under `gitea.config` that contain a dot should be written as ```yml "section.header": key1: value1 ``` Without the quotes, helm will split the section name into two parts consistent of "section" and "header" whereas they should appear "as is" in `app.ini`, i.e. `"section.header"`.

pat-s pinned this 2023-09-22 15:30:30 +00:00

justusbunsi commented

2023-09-22 15:46:24 +00:00

🤔 It's documented how to pass settings containing a . in our Helm Chart (general information: https://gitea.com/gitea/helm-chart#configuration, cross references for ConfigMaps and Secrets: https://gitea.com/gitea/helm-chart#additional-_appini_-settings).

I understand the intention of the GitHub issue, like the idea and understand the limits. Should we extend our documentation by that quoting hint?

🤔 It's documented how to pass settings containing a `.` in our Helm Chart (general information: https://gitea.com/gitea/helm-chart#configuration, cross references for ConfigMaps and Secrets: https://gitea.com/gitea/helm-chart#additional-\_appini\_-settings). I understand the intention of the GitHub issue, like the idea and understand the limits. Should we extend our documentation by that quoting hint?

pat-s commented

2023-09-22 16:07:31 +00:00

I understand the intention of the GitHub issue, like the idea and understand the limits. Should we extend our documentation by that quoting hint?

More is always better I'd say :) I just wanted to give it a bit more visibility with the issue and pin as many users will probably overlook it in our super long README :)

> I understand the intention of the GitHub issue, like the idea and understand the limits. Should we extend our documentation by that quoting hint? More is always better I'd say :) I just wanted to give it a bit more visibility with the issue and pin as many users will probably overlook it in our super long README :)

justusbunsi commented

2023-09-22 16:15:35 +00:00

Without the quotes, helm will split the section name into two parts consistent of "section" and "header"

How did you get Helm to split the settings during processing? Did you pass the setting via --set CLI parameter? I never encountered that issue in the past.

> Without the quotes, helm will split the section name into two parts consistent of "section" and "header" How did you get Helm to split the settings during processing? Did you pass the setting via `--set` CLI parameter? I never encountered that issue in the past.

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#516

Usage advice: quote app.ini section headers in values.yml if they contain a dot #516

Usage advice: quote `app.ini` section headers in `values.yml` if they contain a dot #516