Namespace inconsistencies #623
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#623
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hey!
First off, I have to say what an awesome product Gitea is! 👏
I'm currently deploying Gitea to a local cluster and I noticed that the helm chart will not apply the Helm release namespace to the actual Gitea deployment, meaning that it ends up in the default namespace unless applied with a namespace flag.
Since I'm using
cdk8s
, my resulting manifests have no namespace, and I can override this when applying, but there's some inconsistency as other components do apply the namespace:{{ .Release.Namespace | quote }}
)I know that different projects provided different means for this (
.Release.Namespace
,.Values.namespaceOverride
, etc.) but I think most projects have standardised on.Release.Namespace
now.Fair point. If you can, please open a PR to fix this.
More than happy to, just wanted to check if this is something you wanted me to pursue first.
Check #630 for expanded use case for the implementation @absolutejam if you get to the PR before me please take it into account. Otherwise I believe my straw man solution should help you as well.