Allow existing secrets for passwords #170

Merged
lunny merged 3 commits from allow-secrets-for-password into master 2021-06-10 11:13:33 +00:00
Member

Allow admin user and password to be configured via existing secrets

Allow LDAP bindDn and bindPassword to be configured via existing secrets

Update Readme

Fixes: #169

Allow admin user and password to be configured via existing secrets Allow LDAP bindDn and bindPassword to be configured via existing secrets Update Readme Fixes: #169
Author
Member

Tested on my cluster

Tested on my cluster
First-time contributor

Tested on my cluster too.
Seems working fine!
Thank you!

Tested on my cluster too. Seems working fine! Thank you!
techknowlogick approved these changes 2021-06-08 17:04:01 +00:00
justusbunsi reviewed 2021-06-09 14:00:57 +00:00
README.md Outdated
@ -309,0 +341,4 @@
```yaml
gitea:
admin:
Member

Whouldn't it be gitea.ldap.existingSecret instead of gitea.admin.existingSecret for the ldap configuration?

Whouldn't it be `gitea.ldap.existingSecret` instead of `gitea.admin.existingSecret` for the ldap configuration?
Author
Member

good catch!

good catch!
luhahn marked this conversation as resolved
luhahn force-pushed allow-secrets-for-password from b62cde2aab to 7f2d439745 2021-06-09 14:41:32 +00:00 Compare
luhahn force-pushed allow-secrets-for-password from 7f2d439745 to 084cd19123 2021-06-09 14:56:34 +00:00 Compare
Author
Member

Fixed another bug and updated the branch with the current master

Fixed another bug and updated the branch with the current master
First-time contributor

@luhahn shouldn't you approve this also?

@luhahn shouldn't you approve this also?
Author
Member

@luhahn shouldn't you approve this also?

You can't approve your own PRs :)

> @luhahn shouldn't you approve this also? You can't approve your own PRs :)
lunny approved these changes 2021-06-10 11:12:57 +00:00
lunny merged commit c49dc047a4 into master 2021-06-10 11:13:33 +00:00
Contributor

This pr is again a breaking change for existing users ? see #179

This pr is again a breaking change for existing users ? see #179
Sign in to join this conversation.
No description provided.