Rework OAuth sources #244
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Blocks
Depends on
#240 Generic way for configuring Gitea app.ini
gitea/helm-chart
#248 Drop custom probes
gitea/helm-chart
Reference: gitea/helm-chart#244
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "justusbunsi/helm-chart:feature/191-multiple-oauth-sources"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This change request includes two different things to improve OAuth source handling:
⚠️ BREAKING ⚠️
Users need to migrate their
gitea.oauth
configuration.@ -139,3 +139,3 @@
{{- define "gitea.oauth_settings" -}}
{{- range $key, $val := .Values.gitea.oauth -}}
{{- $idx := index . 0 }}
we could add oauth password/secret key deployment via existing secrets like in the ldap settings. Otherwise idx won't be needed here.
c5a405f857
to729f95b26a
729f95b26a
toaf5ae13c7d
af5ae13c7d
toe5733e7400
Add support for multiple OAuth sourcesto WIP: Add support for multiple OAuth sourcesWIP: Add support for multiple OAuth sourcesto WIP: Rework OAuth sourcesWIP: Rework OAuth sourcesto Rework OAuth sources#248 was merged, we can continue here :)
Yay ?
Updated and ready for review
8ba6cad90f
to1e917cca73
LGTM
this conversion of yaml to cli options seems quite fragile and hacky.
We may want to consider having commands that would ingest the yaml directly.
However, if you're certain that this is the correct approach then LGTM.
@zeripath It is fragile and hacky.? I would consider it the right approach at the moment.
Literally a few hours ago I had a chat with luhahn about a quite generic way of having a configuration-as-code for Gitea natively. There are other tools like Jenkins with a plugin providing such stuff and it is awesome. I'll try to implement something similar in Gitea and create a PR for it to discuss a bit more but am not sure when I have enough time for it as I'm not so deep into the Gitea code.
I would like to point out that this fails currently (Using flux so that variable subtition is fine):
The log seems to be trimmed. Do you have the full log?
And: Have you tried this with the latest released 1.4.1? I've never encountered such a problem before.
In addition: Did Flux actually fetch new source for the Helm Chart yet?
@samip537 It looks like you're using an old version, "gitea.oauth_settings" at <ne $key "enabled">: the enabled key was removed with this PR.
Please notice, that the current master branch has not been released
Hi @samip537. I've tested FluxCD with the latest master source code for the Helm Chart and it works as expected. You can find my used Flux resources in my test repository:
We also opened PR #267 to make sure the obsolete and now invalid option
enabled
won't cause problems in the future.Ahh, okey. Somehow I thought that it was already released, my bad but then that makes perfect sense. :)