gitea/helm-chart
45
55
Fork 125
Code Issues 32 Pull Requests 8 Actions Releases 87 Activity

Explicit pass config file via cli #289

Closed
viceice wants to merge 1 commits from viceice:fix/gitea-config-arg into main
pull from: viceice:fix/gitea-config-arg
merge into: gitea:main
Conversation 3 Commits 1 Files Changed 1 +2
viceice commented 2022-02-01 11:47:46 +00:00
Contributor
Copy Link

Explicitly pass config file via cli, otherwise it get's wrongly overwritten by docker files

Explicitly pass config file via cli, otherwise it get's wrongly overwritten by docker files - fixes #287
viceice added 1 commit 2022-02-01 11:47:47 +00:00
Explicit pass config file
All checks were successful
continuous-integration/drone/pr Build is passing
Details
434dbb678b
justusbunsi commented 2022-02-01 16:03:20 +00:00
Member
Copy Link

The alias is only set within the init container. Wouldn't it be still broken for the actual container running Gitea? It uses the same image.

I saw you already proposed https://github.com/go-gitea/gitea/pull/18524 as upstream fix. ?

The alias is only set within the init container. Wouldn't it be still broken for the actual container running Gitea? It uses the same image. I saw you already proposed https://github.com/go-gitea/gitea/pull/18524 as upstream fix. ?
justusbunsi commented 2022-02-10 13:33:32 +00:00
Member
Copy Link

I'd prefer to update Gitea version as soon as 1.16.2 is released. Using an alias looks like a neat but really dirty fix for this issue. ?

I'd prefer to update Gitea version as soon as 1.16.2 is released. Using an alias looks like a neat but really dirty fix for this issue. ?
techknowlogick commented 2022-02-25 22:12:16 +00:00
Owner
Copy Link

Closing as I have merged the PR with the update to 1.16.2 which includes the fix for this.

Closing as I have merged the PR with the update to 1.16.2 which includes the fix for this.
techknowlogick closed this pull request 2022-02-25 22:12:16 +00:00
viceice deleted branch fix/gitea-config-arg 2022-08-24 13:44:42 +00:00
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#289
No description provided.
Delete Branch "viceice:fix/gitea-config-arg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?