gitea/helm-chart
49
61
Fork 134
Code Issues 38 Pull Requests 8 Actions Releases 91 Activity

Allow configuration of ipFamilyPolicy and ipFamilies #313

Merged
luhahn merged 3 commits from svenihoney/helm-chart:master into master 2022-04-25 11:56:26 +00:00
Conversation 2 Commits 3 Files Changed 4 +26
svenihoney commented 2022-04-17 09:02:05 +00:00
Contributor
Copy Link

To enable access to e.g. the SSH port by IPv6, the selection of ipFamilyPolicy and ipFamilies service attributes is necessary. Enable the possibility to configure these by helm values.

To enable access to e.g. the SSH port by IPv6, the selection of ipFamilyPolicy and ipFamilies service attributes is necessary. Enable the possibility to configure these by helm values.
svenihoney added 1 commit 2022-04-17 09:02:06 +00:00
Allow configuration of ipFamilyPolicy and ipFamilies
All checks were successful
continuous-integration/drone/pr Build is passing
Details
338b9db937
svenihoney added 1 commit 2022-04-17 09:03:42 +00:00
Add placeholders for ipFamilyPolicy and ipFamilies to values file
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5b511d8688
techknowlogick commented 2022-04-21 03:59:45 +00:00
Owner
Copy Link

Thanks for the PR :)

From a purely diff perspective, these changes look fine, although I'm not familiar enough with the ipfamily service attributes enough to say either way.

If another maintainer is fine with these too, then I'm happy to give my approval as well.

Thanks for the PR :) From a purely diff perspective, these changes look fine, although I'm not familiar enough with the ipfamily service attributes enough to say either way. If another maintainer is fine with these too, then I'm happy to give my approval as well.
justusbunsi requested changes 2022-04-21 09:30:15 +00:00
justusbunsi left a comment
Member
Copy Link

In addition to the comments below, please add both new value parameters to the service section of README.md. Since the default value depend on each environment, I'd suggest linking the official Kubernetes dual-stack concept documentation: https://kubernetes.io/docs/concepts/services-networking/dual-stack/

In addition to the comments below, please add both new value parameters to the service section of [README.md](https://gitea.com/gitea/helm-chart/src/branch/master/README.md#service). Since the default value depend on each environment, I'd suggest linking the official Kubernetes dual-stack concept documentation: https://kubernetes.io/docs/concepts/services-networking/dual-stack/
templates/gitea/http-svc.yaml Outdated
@ -21,6 +21,13 @@ spec:
externalIPs:
{{- toYaml .Values.service.http.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.ipFamilyPolicy }}
justusbunsi commented 2022-04-21 09:18:08 +00:00
Member
Copy Link
- {{- if .Values.service.ipFamilyPolicy }}
+ {{- if .Values.service.http.ipFamilyPolicy }}
```diff - {{- if .Values.service.ipFamilyPolicy }} + {{- if .Values.service.http.ipFamilyPolicy }} ```
justusbunsi marked this conversation as resolved
templates/gitea/http-svc.yaml Outdated
@ -22,2 +22,4 @@
{{- toYaml .Values.service.http.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.ipFamilyPolicy }}
ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }}
justusbunsi commented 2022-04-21 09:18:40 +00:00
Member
Copy Link
- ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }}
+ ipFamilyPolicy: {{ .Values.service.http.ipFamilyPolicy }}
```diff - ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }} + ipFamilyPolicy: {{ .Values.service.http.ipFamilyPolicy }} ```
justusbunsi marked this conversation as resolved
templates/gitea/http-svc.yaml Outdated
@ -24,0 +24,4 @@
{{- if .Values.service.ipFamilyPolicy }}
ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }}
{{- end }}
{{- with .Values.service.ipFamilies }}
justusbunsi commented 2022-04-21 09:19:52 +00:00
Member
Copy Link
- {{- with .Values.service.ipFamilies }}
+ {{- with .Values.service.http.ipFamilies }}
```diff - {{- with .Values.service.ipFamilies }} + {{- with .Values.service.http.ipFamilies }} ```
justusbunsi marked this conversation as resolved
templates/gitea/ssh-svc.yaml Outdated
@ -26,6 +26,13 @@ spec:
externalIPs:
{{- toYaml .Values.service.ssh.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.ipFamilyPolicy }}
justusbunsi commented 2022-04-21 09:22:09 +00:00
Member
Copy Link

Like above but with .ssh. values subpath for this whole file.

Like above but with `.ssh.` values subpath for this whole file.
justusbunsi marked this conversation as resolved
justusbunsi added the
kind
feature
 label 2022-04-21 09:30:39 +00:00
svenihoney added 1 commit 2022-04-21 15:41:10 +00:00
Correct yaml reference for dual-stack parameters
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5d048aceeb 
Added documentation of parameters to README.md.
svenihoney requested review from justusbunsi 2022-04-21 15:42:54 +00:00
justusbunsi approved these changes 2022-04-21 19:04:49 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
justusbunsi commented 2022-04-21 19:22:05 +00:00
Member
Copy Link

If another maintainer is fine with these too, then I'm happy to give my approval as well.

@techknowlogick Ready for your approval. ?

> If another maintainer is fine with these too, then I'm happy to give my approval as well. @techknowlogick Ready for your approval. ?
luhahn approved these changes 2022-04-25 11:55:36 +00:00
luhahn left a comment
Member
Copy Link

LGTM

LGTM
luhahn merged commit 52ed32ae74 into master 2022-04-25 11:56:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justusbunsi
luhahn
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#313
No description provided.
Delete Branch "svenihoney/helm-chart:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?