gitea
/
helm-chart
35
28
Fork 67
Code Issues 36 Pull Requests 7 Releases 48 Wiki Activity
Labels Milestones

Properly lock chart dependencies #326

Merged
luhahn merged 2 commits from justusbunsi/helm-chart:dependency-hardening into master 2 months ago
Conversation 0 Commits 2 Files Changed 3
justusbunsi commented 2 months ago
Collaborator

As mentioned in the Bitnami chart issue, they've created a git tag to
represent the latest full content index.yaml. This should be used
instead of a commit that could be changed.

https://github.com/bitnami/charts/issues/10539#issuecomment-1152641771

I've also removed the Chart.lock file from the ignore list. This file
ensures correct dependency retrieval when using helm dependency build.

https://helm.sh/docs/helm/helm_dependency_build/#helm-dependency-build

Signed-off-by: justusbunsi sk.bunsenbrenner@gmail.com

As mentioned in the Bitnami chart issue, they've created a git tag to represent the latest full content `index.yaml`. This should be used instead of a commit that could be changed. https://github.com/bitnami/charts/issues/10539#issuecomment-1152641771 I've also removed the `Chart.lock` file from the ignore list. This file ensures correct dependency retrieval when using `helm dependency build`. https://helm.sh/docs/helm/helm_dependency_build/#helm-dependency-build Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
justusbunsi added 1 commit 2 months ago
continuous-integration/drone/pr Build is passing
Details
20c727a5a0
Properly lock chart dependencies
techknowlogick approved these changes 2 months ago
justusbunsi added 1 commit 2 months ago
luhahn approved these changes 2 months ago
luhahn left a comment
Collaborator

LGTM

LGTM
luhahn merged commit 0172a59889 into master 2 months ago
luhahn referenced this issue from a commit 2 months ago
Properly lock chart dependencies (#326)
justusbunsi deleted branch dependency-hardening 2 months ago

Reviewers

techknowlogick approved these changes 2 months ago
luhahn approved these changes 2 months ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 0172a59889.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
techknowlogick
luhahn
Labels
Apply labels
Clear labels
has/backport in progress invalid kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/lint kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation kind/ui need/backport priority/critical priority/low priority/maybe priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/other
No Label has/backport in progress invalid kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/lint kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation kind/ui need/backport priority/critical priority/low priority/maybe priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/other
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#326
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'justusbunsi/helm-chart:dependency-hardening'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes