gitea/helm-chart
49
58
Fork 132
Code Issues 34 Pull Requests 8 Actions Releases 90 Activity

Remove mysql and mariadb chart deps #417

Merged
justusbunsi merged 6 commits from remove-mysql-mariadb into main 2023-03-28 17:02:05 +00:00
Conversation 0 Commits 6 Files Changed 6 +13 -110
pat-s commented 2023-03-25 10:07:13 +00:00
Member
Copy Link

As discussed in Discord.

Supersedes #412 and #407.

⚠️ BREAKING

Users depending on the built-in MySQL or MariaDB chart have to switch to an self-managed database, or Postgres

As discussed in Discord. Supersedes #412 and #407. **⚠️ BREAKING** Users depending on the built-in MySQL or MariaDB chart have to switch to an self-managed database, or Postgres
pat-s added 1 commit 2023-03-25 10:07:14 +00:00
remove mysql and mariadb
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
0300c8a10e
pat-s added 1 commit 2023-03-25 10:12:47 +00:00
add missing {{- end -}}
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
24229e024d
pat-s requested review from justusbunsi 2023-03-25 10:14:00 +00:00
pat-s requested review from techknowlogick 2023-03-25 10:14:07 +00:00
justusbunsi requested changes 2023-03-27 16:31:23 +00:00
justusbunsi left a comment
Member
Copy Link

Besides the commented parts, L-G-T-M.

Besides the commented parts, L-G-T-M.
README.md Outdated
@ -889,4 +862,2 @@
postgresql:
enabled: true
mysql:
justusbunsi commented 2023-03-27 16:22:14 +00:00
Member
Copy Link

I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.

I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.
justusbunsi marked this conversation as resolved
README.md Outdated
@ -238,1 +236,3 @@
An external Database can be used instead of builtIn PostgreSQL or MySQL.
Any external Database listed in [https://docs.gitea.io/en-us/database-prep/](https://docs.gitea.io/en-us/database-prep/) can be used instead of the built-in PostgreSQL.
In fact, it is **highly recommended** to use an external database to ensure a stable Gitea installation longterm.
The built-in dependency is mainly for testing and development purposes.
justusbunsi commented 2023-03-27 16:28:52 +00:00
Member
Copy Link

While I agree with the recommendation to use an external database for a longterm stable Gitea installation, I don't agree that the built-in dependency is mainly for testing an development purposes. If that would be the case, we wouldn't release the dependency but instead have it located somewhere in a testing folder or similar to boostrap the dev environment with it.
If users decide to rely on the built-in database, they can do so by accepting all the changes we make - e.g. updating. That is totally fine in my opinion.

While I agree with the recommendation to use an external database for a longterm stable Gitea installation, I don't agree that the built-in dependency is mainly for testing an development purposes. If that would be the case, we wouldn't release the dependency but instead have it located somewhere in a `testing` folder or similar to boostrap the dev environment with it. If users decide to rely on the built-in database, they can do so by accepting all the changes we make - e.g. updating. That is totally fine in my opinion.
justusbunsi marked this conversation as resolved
README.md Outdated
@ -878,3 +851,3 @@
The values to enable the dependencies,
such as PostgreSQL, Memcached, MySQL and MariaDB
such as PostgreSQL or Memcached.
justusbunsi commented 2023-03-27 16:21:59 +00:00
Member
Copy Link

I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.

I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.
justusbunsi marked this conversation as resolved
pat-s reviewed 2023-03-27 17:22:16 +00:00
README.md Outdated
@ -889,4 +862,2 @@
postgresql:
enabled: true
mysql:
pat-s commented 2023-03-27 17:22:12 +00:00
Author
Member
Copy Link

Agreed!

Agreed!
justusbunsi marked this conversation as resolved
pat-s reviewed 2023-03-27 17:23:30 +00:00
README.md Outdated
@ -238,1 +236,3 @@
An external Database can be used instead of builtIn PostgreSQL or MySQL.
Any external Database listed in [https://docs.gitea.io/en-us/database-prep/](https://docs.gitea.io/en-us/database-prep/) can be used instead of the built-in PostgreSQL.
In fact, it is **highly recommended** to use an external database to ensure a stable Gitea installation longterm.
The built-in dependency is mainly for testing and development purposes.
pat-s commented 2023-03-27 17:23:23 +00:00
Author
Member
Copy Link

Fair point! I removed the respective sentence.

Fair point! I removed the respective sentence.
justusbunsi marked this conversation as resolved
pat-s added 3 commits 2023-03-27 17:23:56 +00:00
remove dev/testing sentence
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
b7c69f79cf
pat-s requested review from justusbunsi 2023-03-27 17:24:12 +00:00
pat-s added 1 commit 2023-03-27 17:27:38 +00:00
lint
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a3ab735a37
justusbunsi approved these changes 2023-03-27 17:31:56 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
jolheiser approved these changes 2023-03-28 16:53:46 +00:00
yardenshoham approved these changes 2023-03-28 16:55:43 +00:00
justusbunsi merged commit ae9a71ea11 into main 2023-03-28 17:02:05 +00:00
justusbunsi deleted branch remove-mysql-mariadb 2023-03-28 17:02:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
techknowlogick
justusbunsi
jolheiser
yardenshoham
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#417
No description provided.
Delete Branch "remove-mysql-mariadb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?