gitea/helm-chart
48
59
Fork 134
Code Issues 41 Pull Requests 11 Actions Releases 90 Activity

Add non-clustered redis as sub-chart #672

Merged
justusbunsi merged 20 commits from 559 into main 2024-07-07 09:57:17 +00:00
Conversation 1 Commits 20 Files Changed 11 +163 -21
pat-s commented 2024-07-02 08:44:40 +00:00
Member
Copy Link

Supersedes #559 (@julienym thanks a lot for the initial work, I just cleaned up and added some minor edits. Needed to do so in a new branch as I can't directly edit your fork.)

@justusbunsi I've tested this in a fresh install without issues. Given the tests added by @julienym I am fine with merging this. I'll leave this open a few days so you get a chance to take a final look. No worries, if you have no time, we can always make post-merge adjustments/fixes.

Supersedes #559 (@julienym thanks a lot for the initial work, I just cleaned up and added some minor edits. Needed to do so in a new branch as I can't directly edit your fork.) @justusbunsi I've tested this in a fresh install without issues. Given the tests added by @julienym I am fine with merging this. I'll leave this open a few days so you get a chance to take a final look. No worries, if you have no time, we can always make post-merge adjustments/fixes.
pat-s added the
kind
feature
 label 2024-07-02 08:44:40 +00:00
pat-s added 12 commits 2024-07-02 08:44:41 +00:00
up
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
9a80afa66b
Merge remote-tracking branch 'upstream/main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
aefd762d44
update lock
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
bf79b78178
update redis chart version
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
1783d13d4e
update readme
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
e74e21ef13
fix helper
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
86e26f5a0d
adjust unittests
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
d0684d4149
add readme info
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 35s
Details
ebab718526
pat-s requested review from justusbunsi 2024-07-02 08:44:41 +00:00
pat-s added 1 commit 2024-07-02 08:45:57 +00:00
lint
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
7186848570
justusbunsi commented 2024-07-02 16:14:57 +00:00
Member
Copy Link

🫡 Will take a closer look in the next days. Thanks for the ping.

🫡 Will take a closer look in the next days. Thanks for the ping.
justusbunsi added 5 commits 2024-07-05 19:09:49 +00:00 
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
83d474c3da/bitnami/redis/templates/master/application.yaml (L20C17-L20C36)

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Drop ineffective production single-pod settings
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 36s
Details
90612e91c8 
As discovered in #585 (comment) (bottom part),
as long as an Chart internal redis is enabled (no matter which), users
are not able to overrule its settings.

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
justusbunsi approved these changes 2024-07-05 19:22:49 +00:00
justusbunsi left a comment
Member
Copy Link

As you can see, I changed a few things. My commit messages should be descriptive. If not, let me know.
LGTM now. I keep it up to you to merge this PR. That way you have the chance to review my changes.

As you can see, I changed a few things. My commit messages should be descriptive. If not, let me know. LGTM now. I keep it up to you to merge this PR. That way you have the chance to review my changes.
Makefile
@ -10,3 +10,3 @@
.PHONY: unittests
unittests:
helm unittest --strict -f 'unittests/**/*.yaml' -f 'unittests/dependency-major-image-check.yaml' ./
helm unittest --strict -f 'unittests/**/*.yaml' -f 'unittests/dependency-major-image-check.yaml' -f 'unittests/values-conflicting-checks.yaml' ./
justusbunsi commented 2024-07-05 19:19:24 +00:00
Member
Copy Link

Thinking out loud:
There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd -f. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)

Thinking out loud: There was a time when the unittest plugin didn't recognize the test files on root level when using that pattern. Nowadays this works. So in theory we could remove the 2nd and 3rd `-f`. But adding them will prevent possible regressions in the unittest plugin which would disable our checks. That's why I added the new file. :)
justusbunsi added 2 commits 2024-07-07 09:55:15 +00:00
Bump non-clustered redis to latest version
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 38s
Details
a4ef974905 
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
justusbunsi merged commit 6226e4eaea into main 2024-07-07 09:57:17 +00:00
justusbunsi deleted branch 559 2024-07-07 09:57:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justusbunsi
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#672
No description provided.
Delete Branch "559"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?