Fix Ingress #70
No reviewers
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#70
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix-ingress"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since there was a little mess up with ingress
I've reworked the api check for which version we're running.
Also added pathType to ingress, since it is required in v1 and optional in v1beta1.
Tested on my clusters with ingress running. Both versions, v1beta1 and v1.
@ -2,3 +2,3 @@
{{- $fullName := include "gitea.fullname" . -}}
{{- $httpPort := .Values.service.http.port -}}
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}}
Shouldn't these checks be more explicit, something like
.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress"
?I currently get the following error on my cluster:
It seems I have networkpolicies in v1 but not ingress:
Encountered the same issue. That's because ingress has been moved to /v1 with Kubernetes 1.19+ but still in /v1beta1 in 1.18 (which I am running).
Still need to check the cluster version I guess.
will have a look at it tomorrow, thanks for finding this.