gitea/helm-chart
45
55
Fork 125
Code Issues 32 Pull Requests 8 Actions Releases 87 Activity

bugfix/ingress-capabilities-query #78

Merged
lafriks merged 2 commits from skuethe/helm-chart:bugfix/ingress-capabilities-query into master 2020-12-08 12:57:52 +00:00
Conversation 3 Commits 2 Files Changed 1 +3 -3
skuethe commented 2020-12-04 09:15:43 +00:00
Contributor
Copy Link

I didn't find any contributing guidelines, so bare with me if this is not the preferred way for fixes :)

Also just "highjacking" the "fix-ingress" branch for this. Should fix #77

I didn't find any contributing guidelines, so bare with me if this is not the preferred way for fixes :) Also just "highjacking" the "fix-ingress" branch for this. Should fix [#77](https://gitea.com/gitea/helm-chart/issues/77)
skuethe added 2 commits 2020-12-04 09:15:44 +00:00
Fix Ingress (#70) 
Bump chart version to 2.0.7

Fix Ingress

- Ingress uses now .Capabilities.APIVersions.Has to compare the api version available
- Added pathType since it is required in v1 and optional in v1beta1

Co-authored-by: Lucas Hahn <lucas.hahn@novum-rgi.de>
Reviewed-on: #70
Reviewed-by: Andrew Thornton <art27@cantab.net>
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-Authored-By: luhahn <luhahn@noreply.gitea.io>
Co-Committed-By: luhahn <luhahn@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/tag Build is passing
Details
63bc10e393
fixing capabilities query for Ingress on 1.18 and older
Some checks failed
continuous-integration/drone/pr Build is failing
Details
a3b0e418fa
luhahn commented 2020-12-04 10:55:53 +00:00
Member
Copy Link

Hi there,

please point the pull request onto master instead of fix-ingress branch. Also please rebase your branch onto master, since fix-ingress branch is not up to date with the latest master :).

Hi there, please point the pull request onto master instead of fix-ingress branch. Also please rebase your branch onto master, since fix-ingress branch is not up to date with the latest master :).
skuethe changed target branch from fix-ingress to master 2020-12-04 11:27:32 +00:00
skuethe commented 2020-12-04 11:31:29 +00:00
Author
Contributor
Copy Link

Yeah that was probably a bad idea. Should have taken master in the first place, but was unsure what your policies are :)

I modified the PR to go into master - as my branch was created from master fork, this should "do it", right?

Yeah that was probably a bad idea. Should have taken master in the first place, but was unsure what your policies are :) I modified the PR to go into master - as my branch was created from master fork, this should "do it", right?
techknowlogick added 1 commit 2020-12-06 23:57:18 +00:00
Merge branch 'master' into bugfix/ingress-capabilities-query
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7a9584f1c8
luhahn approved these changes 2020-12-07 08:58:33 +00:00
Dismissed
luhahn left a comment
Member
Copy Link

Tested, looks good to me.Though i cannot test on Kubernetes 1.18 currently

Tested, looks good to me.Though i cannot test on Kubernetes 1.18 currently
luhahn commented 2020-12-08 08:34:30 +00:00
Member
Copy Link

Was tested on 1.18.6 as well

Was tested on 1.18.6 as well
lafriks approved these changes 2020-12-08 12:57:05 +00:00
Dismissed
lafriks added the
kind
bug
 label 2020-12-08 12:57:14 +00:00
lafriks merged commit 1b21ce2810 into master 2020-12-08 12:57:52 +00:00
lafriks deleted branch bugfix/ingress-capabilities-query 2020-12-08 12:57:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#78
No description provided.
Delete Branch "skuethe/helm-chart:bugfix/ingress-capabilities-query"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?