gitea/homebrew-gitea
44
15
Fork 20
Code Issues 2 Pull Requests Actions Releases Wiki Activity

Fix homebrew tap by removing head and shipping compiled binaries #136

Merged
techknowlogick merged 1 commits from markkrj/homebrew-gitea:fix-brew-tap into master 2021-06-29 18:00:18 +00:00
Conversation 0 Commits 1 Files Changed 5 +143 -100
markkrj commented 2021-06-29 17:20:23 +00:00
Contributor
Copy Link

fixes #135

This fix Homebrew tap by removing the head method and shipping only pre-compiled binaries, as you guys already ship binaries for most (all?) supported platforms.

Also, for gitea.rb and tea.rb, I removed the curl for fetching files checksum, because for every install, it runs curl 5 times, slowing the install. So, I created a script to bump versions to latest and fix sha256 checksum in the formula files.

I created also an gitea-head and tea-head formulae to download latest pre-compiled binaries for head, and here we are fetching checksum by curl, as I imagine, it is not common/recommended scenario.

IMO, this is the best possible approach for shipping binaries from a custom tap.

fixes #135 This fix Homebrew tap by removing the head method and shipping only pre-compiled binaries, as you guys already ship binaries for most (all?) supported platforms. Also, for gitea.rb and tea.rb, I removed the curl for fetching files checksum, because for every install, it runs `curl` 5 times, slowing the install. So, I created a script to bump versions to latest and fix sha256 checksum in the formula files. I created also an gitea-head and tea-head formulae to download latest pre-compiled binaries for head, and here we are fetching checksum by `curl`, as I imagine, it is not common/recommended scenario. IMO, this is the best possible approach for shipping binaries from a custom tap.
❤️ 2
markkrj added 1 commit 2021-06-29 17:20:24 +00:00
techknowlogick approved these changes 2021-06-29 17:39:30 +00:00
techknowlogick left a comment
Owner
Copy Link

Awesome. Thank you so much!!!

Awesome. Thank you so much!!!
techknowlogick merged commit 10c0dc82d8 into master 2021-06-29 18:00:18 +00:00
markkrj deleted branch fix-brew-tap 2021-06-29 18:09:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
techknowlogick
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/homebrew-gitea#136
No description provided.
Delete Branch "markkrj/homebrew-gitea:fix-brew-tap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?