Make flags marshallable #2

zeripath · 2019-05-24T20:58:43Z

zeripath commented

2019-05-24 20:58:43 +00:00

Flags should be marshallable.

lunny requested changes 2019-05-26 08:50:50 +00:00

Dismissed

flags.go

						
				@ -35,3 +41,3 @@

				)

				var flagFromString = map[string]int{

				var flagFromString = map[string]Flags{

lunny commented

2019-05-26 08:50:17 +00:00

I think since flagOrder is exist, this map is unnecessary. There is no performance difference between traversing map and traversing slice when there are some few items.

I think since `flagOrder` is exist, this map is unnecessary. There is no performance difference between traversing map and traversing slice when there are some few items.

zeripath commented

2019-05-26 14:16:49 +00:00

The index of the flagOrder array is not the value of the flag.

lunny commented

2019-05-26 15:51:12 +00:00

OK. This will not the blocker.

zeripath commented

2019-05-26 17:41:46 +00:00

Sorry I was being stupid - So long as we keep orderFlag in the same order as the declaration we can just use Flags(1<< uint64(i)) to get the flag value.

Sorry I was being stupid - So long as we keep orderFlag in the same order as the declaration we can just use `Flags(1<< uint64(i))` to get the flag value.

lunny approved these changes 2019-05-26 15:51:43 +00:00

Dismissed

jonasfranz approved these changes 2019-06-03 07:00:37 +00:00

Dismissed

zeripath closed this pull request

2019-06-03 07:59:43 +00:00

zeripath deleted branch marshal-flags

2019-06-03 07:59:57 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/log#2