gitea/log
Archived
48
4
Fork 6
Code Issues 5 Pull Requests 4 Releases Wiki Activity

Init configuration from file #3

Merged
jonasfranz merged 11 commits from zeripath/log:nicer-configuration into master 2019-06-08 10:12:22 +00:00
Conversation 7 Commits 11 Files Changed 2 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit eacd05affd - Show all commits

3
log.go
View File

@ -280,7 +280,8 @@ func init() {
}
// create a default log to write to console
NewLogger(1000, "std", "console", `{"flags":"shortfile,shortfuncname,level,microseconds,date,shortfile", "stacktraceLevel":"error"}`)
NewLogger(1000, "std", "console", fmt.Sprintf(`{"flags":%d, "stacktraceLevel":"error"}`,
lunny commented 2019-06-04 03:22:39 +00:00
Outdated
Review
Copy Link

If config load successfully, the default logger should be disabled I think.

If config load successfully, the default logger should be disabled I think.
zeripath commented 2019-06-05 11:35:31 +00:00
Outdated
Review
Copy Link

Take a look at line 278:

	if configFile != "" {
		err = ConfigureFromFile(configFile)
		if err == nil { 
			return // <- Line 278
		}
	}

if there's no error during configuration from the provided configuration then init() returns here.

Take a look at line 278: ```go if configFile != "" { err = ConfigureFromFile(configFile) if err == nil { return // <- Line 278 } } ``` if there's no error during configuration from the provided configuration then `init()` returns here.
lunny commented 2019-06-06 09:31:42 +00:00
Outdated
Review
Copy Link

OK. Just found we need add reactions on code comments.

OK. Just found we need add reactions on code comments.
FlagsFromString("shortfile,shortfuncname,level,microseconds,date,shortfile")))
hasDefaultLogger = true
if err != nil {
Error("Error reading provided config file: %s Err: %v", configFile, err)