gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

ignore PRs in runIssuesList() (fixes #108) #110

Closed
noerw wants to merge 2 commits from noerw:issue-108/nopulls into main
pull from: noerw:issue-108/nopulls
merge into: gitea:main
Conversation 8 Commits 2 Files Changed 9 +29 -9
noerw commented 2020-03-11 20:23:53 +00:00
Member
Copy Link

fixes #108

Although I kinda think that this should this be solved at API level?
Seems unintuitive for /api/issues to also return pulls.

fixes #108 Although I kinda think that this should this be solved at API level? Seems unintuitive for `/api/issues` to also return pulls.
jolheiser commented 2020-03-11 20:41:56 +00:00
Owner
Copy Link

The API does actually have a way to filter only issues, but it's not in the SDK currently.

See https://try.gitea.io/api/swagger#/issue/issueListIssues type

The API does actually have a way to filter only issues, but it's not in the SDK currently. See https://try.gitea.io/api/swagger#/issue/issueListIssues `type`
6543 commented 2020-03-11 21:18:19 +00:00
Owner
Copy Link

@jolheiser good point!

@jolheiser good point!
6543 added the
status/blocked
kind
enhancement
 labels 2020-03-11 21:18:51 +00:00
6543 added a new dependency 2020-03-11 21:21:07 +00:00
gitea/go-sdk#285 - add ListRepoIssues option for Issue Type
6543 removed the
status/blocked
 label 2020-03-29 21:45:55 +00:00
6543 commented 2020-03-29 22:50:30 +00:00
Owner
Copy Link

@noerw go-sdk taged v0.11.1 so pleace update and you will have the option for issue types

@noerw go-sdk taged v0.11.1 so pleace update and you will have the option for issue types
noerw commented 2020-03-30 13:24:52 +00:00
Author
Member
Copy Link

@6543 Not sure what you did there, but v0.11.1 does not include IssueType:

gitea/issue.go Lines 57 to 62 in ba7916819f
type ListIssueOption struct {
ListOptions
State StateType
Labels []string
KeyWord string
}

@6543 Not sure what you did there, but v0.11.1 does not include `IssueType`: https://gitea.com/gitea/go-sdk/src/commit/ba7916819f3fab3d4205895e4b641a03cc626c90/gitea/issue.go#L57-L62
6543 commented 2020-03-30 14:25:53 +00:00
Owner
Copy Link

@noerw thanks you detect an error ... fixed the wrong tagging ... the wrong sha was tagged.

now it should work: https://gitea.com/gitea/go-sdk/src/tag/gitea/v0.11.1/gitea/issue.go#L51

@noerw thanks you detect an error ... fixed the wrong tagging ... the wrong sha was tagged. now it should work: https://gitea.com/gitea/go-sdk/src/tag/gitea/v0.11.1/gitea/issue.go#L51
noerw commented 2020-03-31 10:57:03 +00:00
Author
Member
Copy Link

Even after cleaning the go module cache, the old sha is still fetched by make vendor.. Maybe some proxy didn't update the sha on v0.11.1? Could we just skip v0.11.1 and tag v0.11.2?

Even after cleaning the go module cache, the old sha is still fetched by `make vendor`.. Maybe some proxy didn't update the sha on v0.11.1? Could we just skip v0.11.1 and tag v0.11.2?
👍 2
6543 commented 2020-03-31 11:48:07 +00:00
Owner
Copy Link

gitea/go-sdk#298

https://gitea.com/gitea/go-sdk/pulls/298
6543 commented 2020-03-31 13:01:57 +00:00
Owner
Copy Link

@noerw -> #111

created pull hope you dont mind :D

@noerw -> #111 created pull hope you dont mind :D
noerw closed this pull request 2020-03-31 13:25:38 +00:00
6543 reviewed 2020-03-31 13:25:44 +00:00
Dismissed
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#285 add ListRepoIssues option for Issue Type
gitea/go-sdk
Reference: gitea/tea#110
No description provided.
Delete Branch "noerw:issue-108/nopulls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?