Add gitea-vet #121

Merged
zeripath merged 10 commits from 6543/tea:add-gitea-vet into master 2020-04-28 13:02:28 +00:00
Owner

close #119

close #119
6543 added the
status/wip
kind/build
labels 2020-04-19 01:25:03 +00:00
Owner

@6543 Having gitea-vet in the gitignore means anyything that matches gitea-vet is ignored, including the vendor directory.

Just needed to change it to /gitea-vet to exclude only the binary.

@6543 Having `gitea-vet` in the gitignore means _anyything_ that matches `gitea-vet` is ignored, including the vendor directory. Just needed to change it to `/gitea-vet` to exclude only the binary.
jolheiser changed title from WIP: Add gitea-vet to Add gitea-vet 2020-04-19 22:18:31 +00:00
jolheiser removed the
status/wip
label 2020-04-19 22:19:43 +00:00
jolheiser approved these changes 2020-04-19 22:20:00 +00:00
Dismissed
appleboy reviewed 2020-04-20 01:31:19 +00:00
Dismissed
@ -1,7 +1,3 @@
// Copyright 2018 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
Member

Why remove License header?

Why remove License header?
Author
Owner

to test if gitea-vet works

the test SHOULD fail!!

to test if gitea-vet works the test SHOULD fail!!
6543 requested review from jolheiser 2020-04-20 01:45:52 +00:00
Author
Owner

@jolheiser the test should fail! I removed a license header to test: see comments ☝️

@jolheiser the test should fail! I removed a license header to test: see comments :point_up:
Owner

Problem was from copy/paste to Makefile

Problem was from copy/paste to `Makefile`
jolheiser requested changes 2020-04-20 20:57:21 +00:00
Dismissed
jolheiser left a comment
Owner

issues.go is missing copyright. 😉

`issues.go` is missing copyright. :wink:
Author
Owner

damed this cp issues - when I find them on other pull's its anoying but ... If I made them its eafen more anoying for me

damed this cp issues - when I find them on other pull's its anoying but ... If I made them its eafen more anoying for me
6543 requested review from jolheiser 2020-04-20 22:41:31 +00:00
Author
Owner

@appleboy now this is ready ;)

@appleboy now this is ready ;)
6543 requested review from appleboy 2020-04-20 22:44:02 +00:00
jolheiser approved these changes 2020-04-21 20:26:59 +00:00
Dismissed
Author
Owner

@appleboy your review is required

@appleboy your review is required
6543 added this to the v0.4.0 milestone 2020-04-28 03:07:15 +00:00
zeripath approved these changes 2020-04-28 13:01:19 +00:00
Dismissed
zeripath merged commit 4b059770ea into master 2020-04-28 13:02:26 +00:00
6543 deleted branch add-gitea-vet 2020-04-28 13:04:46 +00:00
Sign in to join this conversation.
No description provided.