tea login add -s expects a bool instead of string #134

New Issue

pstuifzand · 2020-06-11T05:27:59Z

pstuifzand commented

2020-06-11 05:27:59 +00:00

the login add command expects -s to be boolean. This should be a string.

https://gitea.com/gitea/tea/src/branch/master/cmd/login.go#L58-L62

As seen here:
https://gitea.com/gitea/tea/src/branch/master/cmd/login.go#L111

the login add command expects `-s` to be boolean. This should be a string. https://gitea.com/gitea/tea/src/branch/master/cmd/login.go#L58-L62 As seen here: https://gitea.com/gitea/tea/src/branch/master/cmd/login.go#L111

👍 2 👀 1

6543 added the

kind/bug

label 2020-06-11 10:55:24 +00:00

6543 added this to the v0.3.1 milestone 2020-06-11 10:55:34 +00:00

6543 commented

2020-06-11 10:57:22 +00:00

@pstuifzand would you mind to send a pull?

techknowlogick referenced a pull request that will close this issue

2020-06-11 13:25:14 +00:00

--ssh-key should be string not bool #135

6543 referenced a pull request that will close this issue

2020-06-12 02:38:16 +00:00

Change argument type of ssh-key to String #136

lunny referenced this issue from a commit

2020-06-12 02:43:56 +00:00

--ssh-key should be string not bool (#135) --ssh-key should be string not bool Fix #134 Reviewed-on: https://gitea.com/gitea/tea/pulls/135 Reviewed-by: 6543 <6543@noreply.gitea.io> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>

lunny closed this issue

2020-06-12 02:43:56 +00:00

6543 referenced a pull request that will close this issue

2020-06-15 15:16:48 +00:00

--ssh-key should be string not bool (#135) #137

jolheiser referenced this issue from a commit

2020-06-15 15:27:17 +00:00

--ssh-key should be string not bool (#135) (#137) --ssh-key should be string not bool (#135) --ssh-key should be string not bool Fix #134 Reviewed-on: https://gitea.com/gitea/tea/pulls/135 Reviewed-by: 6543 <6543@noreply.gitea.io> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Reviewed-on: https://gitea.com/gitea/tea/pulls/137 Reviewed-by: John Olheiser <john.olheiser@gmail.com>

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#134