Bugfixes for initCommand #156

6543 · 2020-07-18T07:06:17Z

6543 commented

2020-07-18 07:06:17 +00:00

Loadconfig again (bug introduced by #151)
respect --login parameter

* Loadconfig again (bug introduced by #151) * respect --login parameter

6543 added 1 commit 2020-07-18 07:06:19 +00:00

🚀

continuous-integration/drone/pr Build is passing

Details

b0be3a3566

6543 added the

kind/bug

skip-changelog

labels 2020-07-18 07:06:43 +00:00

6543 added this to the v0.4.0 milestone 2020-07-18 07:06:47 +00:00

lunny approved these changes 2020-07-18 07:08:21 +00:00

Dismissed

6543 added 1 commit 2020-07-18 07:17:40 +00:00

respect --login parameter again

continuous-integration/drone/pr Build is passing

Details

6933551ecf

6543 changed title from ~~Bugfix Loadconfig~~ to Bugfixes for initCommand

2020-07-18 07:21:42 +00:00

zeripath approved these changes 2020-07-18 10:21:12 +00:00

Dismissed

zeripath left a comment

I guess this solves the bug for the present but this is all a bit convoluted
and quite difficult to understand - e.g. there's initCommandLoginOnly()
just below this that appears to use a different way of determining the login.

I think we need to explain these techniques for finding the login - make it
clear where ActiveLogin gets it's login from etc.

I guess this solves the bug for the present but this is all a bit convoluted and quite difficult to understand - e.g. there's initCommandLoginOnly() just below this that appears to use a different way of determining the login. I think we need to explain these techniques for finding the login - make it clear where ActiveLogin gets it's login from etc.

6543 referenced this pull request

2020-07-18 10:43:45 +00:00

Refactor flags.go and config.go #158

6543 referenced this issue from a commit

2020-07-18 10:43:58 +00:00

Bugfixes for initCommand (#156)

6543 merged commit 08a9a9a8ab into master

2020-07-18 10:44:00 +00:00

6543 deleted branch bugfix_loadConfig

2020-07-18 10:44:06 +00:00

Sign in to join this conversation.

No reviewers