tea pulls create
does not work for me #169
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/tea#169
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
I have a local checkout of my fork of this repo:
Expected behaviour:
tea pulls create
will create a pull request to theupstream
remote.Actual behaviour
Instead, it creates a PR on my fork.
It's not great UX, but it's somewhat ok as there are flags to override the target base.
What is not ok, is that these override flags don't work:
--repo flag
is ignored, still publishes on my fork--base flag
fails (with a bad error message)--remote flag
fails (with a bad error message)In addition, to me as a user (with quite some understanding of
tea
internals!) it is totally unclear which of these flag would be the right one, so the help text needs clarification.@6543 You implemented that feature, can you give some insight how the flags listed above are supposed to work?
--repo gitea/tea
should not be ignored but ingeneral--repo at the moment only take paths to cloned repos
☝️ big downside witch I'd like to remove when having some time
@noerw can you test if #178 works for you?
@noerw I'll close this for now, feel free to ask for reopen it
It still doesn't work ;)
--repo
is broken due to #191--remote
still seems not supported. That would be ok for me, but then we should remove this flag from the command.edit:
--remote
correctly sets login, owner, repo, but the call toCreatePullRequest()
yields a404 Not Found
error.I now think this is because it looks for the head branch in the target repo, not in the originating repo, as
head
only contains a branch name.@6543
Can confirm the 404 issue:
It works when calling
tea pr create --remote upstream --head <owner>:<branch>
, where<owner>
is the gitea username of the remote that<branch>
belongs to.So we somehow need to find remote of current branch & extract user name from the remote URL..?