tea pr checkout: fetch via ssh if available #192

As we cant manage multiple remote URLs properly, we just set the correct
URL protocol ahead of time.

This logic won't apply for already existing HTTPS remotes, these
should be deleted before using `tea pr checkout`.

13bad2223c

refactor pulls checkout

isolated "gitea API to local git cfg" aspect

continuous-integration/drone/pr Build is passing

Details

f0f34da41b

noerw added

status/needs-reviews

and removed

status/wip

status/blocked

labels 2020-10-05 11:11:06 +00:00

noerw changed title from ~~WIP: `tea pr checkout`: fetch via ssh if available~~ to `tea pr checkout`: fetch via ssh if available

2020-10-05 11:11:15 +00:00

noerw commented

2020-10-05 11:13:56 +00:00

This one is ready now.

The upstream blocker didn't look like it will be adressed anytime soon, so I implemented a workaround:

When user has configured SSH keys in their gitea account, we will configure the remote in the local repo with the SSH URI.This only applies to new remotes, so already configured HTTPS remotes need to be deleted before running tea pr checkout

This one is ready now. The upstream blocker didn't look like it will be adressed anytime soon, so I implemented a workaround: When user has configured SSH keys in their gitea account, we will configure the remote in the local repo with the SSH URI.This only applies to new remotes, so already configured HTTPS remotes need to be deleted before running `tea pr checkout`

6543 reviewed 2020-10-05 12:24:40 +00:00

Dismissed

cmd/pulls/checkout.go Outdated

						
				@ -8,6 +8,7 @@ import (

					"fmt"

					"log"

					"code.gitea.io/sdk/gitea"

6543 commented

2020-10-05 12:24:40 +00:00

import format :)

noerw marked this conversation as resolved

noerw added 1 commit 2020-10-05 13:50:30 +00:00

reorder imports

continuous-integration/drone/pr Build is passing

Details

47fbecec40

noerw added 1 commit 2020-10-05 14:02:35 +00:00

Merge branch 'master' into issue-190

continuous-integration/drone/pr Build is passing

Details

2f4fff6648

noerw added 1 commit 2020-10-05 14:50:41 +00:00

try to use local branch before creating pulls/<PR>

useful for checking out your own PRs

continuous-integration/drone/pr Build is passing

Details

0bef0385f6

noerw added 1 commit 2020-10-06 10:49:38 +00:00

improved logging

continuous-integration/drone/pr Build is passing

Details

6d850c5ae0

6543 commented

2020-10-10 05:46:15 +00:00

Showld we add aa config option witch decide what to use?

noerw commented

2020-10-21 10:41:51 +00:00

@6543 you mean instead of checking for SSH keys via API? I think using this check is a very good indicator of how the user wants to fetch, and is much lower friction than making them set a config option.

Now that I think about it, user may use tea on a device that has no privkey locally, while having a pubkey in gitea. In that case it would make sense to have an option to override the automatic behaviour.

@6543 you mean instead of checking for SSH keys via API? I think using this check is a very good indicator of how the user wants to fetch, and is much lower friction than making them set a config option. Now that I think about it, user may use tea on a device that has no privkey locally, while having a pubkey in gitea. In that case it would make sense to have an option to override the automatic behaviour.

👍 1

6543 commented

2020-10-22 13:45:38 +00:00

@noerw I think we should add a optional conf ... and user your func by default :)

👍 1

6543 commented

2020-10-22 14:26:36 +00:00

@noerw pleace update this branch :=)

noerw added 1 commit 2020-10-24 12:22:25 +00:00

Merge branch 'master' into issue-190

continuous-integration/drone/pr Build is pending

Details