tea pulls create: detect head branch repo owner #193

Merged
6543 merged 5 commits from noerw/tea:issue-169 into master 2020-09-24 10:44:06 +00:00
Member

fixes #169 (only the --remote / -R flag bug. however the remaining bugs there are tracked in other issues, so it can be closed once this is merged)

this PR finally was created with tea pulls create ?

fixes #169 (only the `--remote` / `-R` flag bug. however the remaining bugs there are tracked in other issues, so it can be closed once this is merged) this PR finally was created with `tea pulls create` ?
noerw added 1 commit 2020-09-19 10:32:17 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
b5567f7542
detect repo owner for default head branch
6543 approved these changes 2020-09-19 11:32:07 +00:00
Dismissed
6543 left a comment
Owner

add more logic - hope this will solve lot of edge cases

add more logic - hope this will solve lot of edge cases
6543 added this to the v0.5.0 milestone 2020-09-19 11:32:27 +00:00
6543 added the
kind/bug
status/needs-reviews
labels 2020-09-19 11:32:38 +00:00
lunny reviewed 2020-09-19 15:38:50 +00:00
Dismissed
cmd/pulls.go Outdated
@ -316,0 +319,4 @@
log.Println("git push")
err = localRepo.Push(&git.PushOptions{})
if err == git.NoErrAlreadyUpToDate {
log.Println(err.Error())
Owner

Why not ignore the error?

Why not ignore the error?
Author
Member

because it is not an error, just information that nothing new was pushed.

because it is not an error, just information that nothing new was pushed.
Owner

@noerw why not ignore this "error" at all (print nothing)

@noerw why not ignore this "error" at all (print nothing)
noerw marked this conversation as resolved
6543 removed the
status/needs-reviews
label 2020-09-21 03:31:42 +00:00
noerw added 3 commits 2020-09-23 10:49:43 +00:00
Author
Member

@lunny this one is ready now

@lunny this one is ready now
Owner

@noerw pleace update :)

@noerw pleace update :)
noerw added 1 commit 2020-09-23 20:14:35 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
387f494383
Merge branch 'master' into issue-169
lunny approved these changes 2020-09-24 05:19:51 +00:00
Dismissed
6543 merged commit 159bf03d49 into master 2020-09-24 10:44:06 +00:00
Sign in to join this conversation.
No description provided.