make subcommands consistently work outside of git repos #200

Closed
opened 2020-09-23 19:58:49 +00:00 by noerw · 0 comments
Member

Currently some subcommands can be run outside of git repos by calling initCommandLoginOnly() instead of initCommand(). This effectively skips git-repo based login selection for the command even when executed inside a git repo, which is not what we want.

So to properly fix this, we need to revamp initCommand() to handle non-existent git repo gracefully instead of erroring, and get rid of initCommandLoginOnly().

#158 covers the same issue i think

Currently some subcommands can be run outside of git repos by calling `initCommandLoginOnly()` instead of `initCommand()`. This effectively skips git-repo based login selection for the command even when executed inside a git repo, which is not what we want. So to properly fix this, we need to revamp `initCommand()` to handle non-existent git repo gracefully instead of erroring, and get rid of `initCommandLoginOnly()`. #158 covers the same issue i think
6543 added the
kind
refactor
label 2020-09-23 20:03:33 +00:00
6543 added the
kind
enhancement
label 2020-09-26 22:50:55 +00:00
6543 added this to the v0.6.0 milestone 2020-09-26 22:51:01 +00:00
noerw added
kind/bug
and removed
kind
enhancement
labels 2020-12-05 22:52:37 +00:00
noerw self-assigned this 2020-12-07 21:14:18 +00:00
noerw added the
status/has-pull
label 2020-12-08 22:59:58 +00:00
6543 referenced this issue from a commit 2020-12-11 09:07:29 +00:00
6543 closed this issue 2020-12-11 09:07:30 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#200
No description provided.