Add Detail View for Login #212

6543 · 2020-10-01T21:19:30Z

6543 commented

2020-10-01 21:19:30 +00:00

Add Detail View for Login
... refactor AddLogin
... make complient with #37
... rm unused code'

Add Detail View for Login ... refactor AddLogin ... make complient with #37 ... rm unused code'

6543 added 3 commits 2020-10-01 21:19:33 +00:00

Remove unused Package + Vars a3d11ad84b

Impruve login comands 45c6f73fb0

Impruve & Refactor AddLogin

continuous-integration/drone/pr Build is passing

Details

5d55e933c6

6543 changed title from ~~Add Detail View for Login ... refactor AddLogin ... make complient with #37 ... rm unused code~~ to Add Detail View for Login

2020-10-01 21:20:22 +00:00

6543 added this to the v0.6.0 milestone 2020-10-01 21:20:26 +00:00

6543 added the

labels 2020-10-01 21:20:43 +00:00

noerw approved these changes 2020-10-01 21:50:23 +00:00

Dismissed

noerw left a comment

Yeah, the refactoring starts to show off! the code has actually become a joy to read ?

noerw added the

kind/breaking

label 2020-10-01 21:54:33 +00:00

noerw commented

2020-10-01 21:55:06 +00:00

Added kind/breaking, as tea login without further args behaves very differently now

Added kind/breaking, as `tea login` without further args behaves very differently now

👍 1

noerw reviewed 2020-10-01 21:58:16 +00:00

Dismissed

modules/setting/setting.go Outdated

						
				@ -6,4 +0,0 @@

				// App related variables

				var (

					AppVer       string

noerw commented

2020-10-01 21:58:16 +00:00

We might need a package like this to implement the debug mode via build tags (i.e. makefile injects -X settings.Tags="debug")?

We might need a package like this to implement the debug mode via build tags (i.e. makefile injects `-X settings.Tags="debug"`)?

6543 commented

2020-10-01 22:08:52 +00:00

make already inject to -X "main.Version=$(TEA_VERSION)" -X "main.Tags=$(TAGS)"

I also think it make more sence to have a flag and set verbose levels

make already inject to `-X "main.Version=$(TEA_VERSION)" -X "main.Tags=$(TAGS)"` I also think it make more sence to have a flag and set verbose levels

noerw commented

2020-10-02 07:13:22 +00:00

what I mean is: we need the debug tag as some global state, and a settings package would be a good fit. but yeah, maybe a flag is better than a tag anyway.

what I mean is: we need the debug tag as some global state, and a `settings` package would be a good fit. but yeah, maybe a flag is better than a tag anyway.

noerw marked this conversation as resolved

zeripath approved these changes 2020-10-02 15:46:54 +00:00

Dismissed

6543 removed the

status/needs-reviews

label 2020-10-02 15:47:29 +00:00

6543 added 1 commit 2020-10-02 15:50:18 +00:00

Merge branch 'master' into refactor_login-and-conf

continuous-integration/drone/pr Build is passing

Details

b08b1b3006

6543 merged commit e23f56e81c into master

2020-10-02 15:57:51 +00:00

6543 referenced this issue from a commit

2020-10-02 15:57:51 +00:00

Add Detail View for Login (#212)

6543 deleted branch refactor_login-and-conf

2020-10-02 15:58:00 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#212