gitea/tea

print times in local timezone #217

Merged

6543 merged 5 commits from noerw/tea:local-time into master

2020-10-05 12:23:41 +00:00

noerw commented

2020-10-04 11:45:37 +00:00

Member

before, times would be shown in UTC. now it is shown in local timezone. if a timezone can't be determined, it still falls back to UTC, but is annotated as such. timezone can be overriden with the TZ env variable.
PR also reduces precision of printed times to minutes instead of seconds.

- before, times would be shown in UTC. now it is shown in local timezone. if a timezone can't be determined, it still falls back to UTC, but is annotated as such. timezone can be overriden with the `TZ` env variable. - PR also reduces precision of printed times to minutes instead of seconds.

noerw added 1 commit 2020-10-04 11:45:39 +00:00

continuous-integration/drone/pr Build is passing

Details

fab5ad1762 use local timezone for all printed times

noerw added the

status/needs-reviews

labels 2020-10-04 11:46:41 +00:00

noerw added 1 commit 2020-10-04 11:51:34 +00:00

continuous-integration/drone/pr Build is passing

Details

02edd6aa24 fixup! use local timezone for all printed times

noerw added 1 commit 2020-10-04 12:03:53 +00:00

continuous-integration/drone/pr Build is passing

Details

82d4fa4598 fixup! use local timezone for all printed times

6543 approved these changes 2020-10-04 15:58:17 +00:00

Dismissed

6543 left a comment

Owner

I'm not a fan of init but I guess it's faster this way

I'm not a fan of `init` but I guess it's faster this way

noerw commented

2020-10-04 16:27:40 +00:00

Author

Member

I just looked at the internals of the time package, and the local zone is looked up only once, so we can get the location everytime without issues

I just looked at the internals of the `time` package, and the local zone is looked up only once, so we can get the location everytime without issues

noerw added 1 commit 2020-10-04 16:34:48 +00:00

continuous-integration/drone/pr Build is passing

Details

16d1531f05 dont resolve location ahead of time

noerw changed title from ~~use local timezone for all times~~ to print times in local timezone

2020-10-04 17:08:29 +00:00

techknowlogick approved these changes 2020-10-05 02:26:17 +00:00

Dismissed

techknowlogick left a comment

Owner

LGTM, please resolve conflicts :)

LGTM, please resolve conflicts :)

techknowlogick removed the

status/needs-reviews

label 2020-10-05 02:27:07 +00:00

noerw added 1 commit 2020-10-05 09:36:13 +00:00

continuous-integration/drone/pr Build is passing

Details

46189e9c83 Merge branch 'master' into local-time

noerw commented

2020-10-05 09:40:36 +00:00

Author

Member

@techknowlogick done :>

@techknowlogick done :>

noerw added this to the v0.6.0 milestone 2020-10-05 11:14:38 +00:00

6543 approved these changes 2020-10-05 12:23:11 +00:00

Dismissed

6543 merged commit 03ec6d0eee into master

2020-10-05 12:23:35 +00:00

6543 referenced this issue from a commit

2020-10-05 12:23:35 +00:00

print times in local timezone (#217)

noerw deleted branch local-time

2020-10-05 14:00:49 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#217

No description provided.