Added organization delete command. #270

khmarbaise · 2020-12-06T22:31:11Z

khmarbaise commented

2020-12-06 22:31:11 +00:00

Fix #269

Signed-off-by: Karl Heinz Marbaise kama@soebes.de

Fix #269 Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>

khmarbaise added 1 commit 2020-12-06 22:31:11 +00:00

Added organization delete command.

Fix #269

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>

continuous-integration/drone/pr Build is passing

Details

73a21773f5

noerw commented

2020-12-06 23:19:23 +00:00

Does this action cascade deletion of repos owned by the organization? In that case we should stop or warn and ask for confirmation.

noerw added the

kind

feature

label 2020-12-06 23:19:32 +00:00

6543 added this to the v0.6.0 milestone 2020-12-06 23:29:59 +00:00

khmarbaise commented

2020-12-06 23:36:06 +00:00

I've created an organization via the administrator. Created an repository within the organization and tried to delete that organization with the following result:

tea (issue-269)$ ./tea org rm test
2020/12/07 00:22:19 Failed to run app with [./tea org rm test]: user still has ownership of repositories [uid: 4]

After that I have deleted the repository and afterwards there is no error message anymore and the organization has been deleted.

I've created an organization via the `administrator`. Created an repository within the organization and tried to delete that organization with the following result: ``` tea (issue-269)$ ./tea org rm test 2020/12/07 00:22:19 Failed to run app with [./tea org rm test]: user still has ownership of repositories [uid: 4] ``` After that I have deleted the repository and afterwards there is no error message anymore and the organization has been deleted.

👍 1

noerw added the

status/needs-reviews

label 2020-12-07 00:00:10 +00:00

6543 reviewed 2020-12-07 00:27:21 +00:00

Dismissed

cmd/organizations/delete.go Outdated

						
				@ -0,0 +35,4 @@

					}

					response, err := client.DeleteOrg(ctx.Args().First())

					if response.StatusCode == 404 {

6543 commented

2020-12-07 00:27:21 +00:00

make sure responce is not nil!!

-	if response.StatusCode == 404 {
+	if response != nil && response.StatusCode == 404 {

make sure responce is not nil!! ```diff - if response.StatusCode == 404 { + if response != nil && response.StatusCode == 404 { ```

khmarbaise commented

2020-12-07 07:52:52 +00:00

outch ... sure... the other question is: Using a literal value for status code is ok? Or do exist in a module constants which could or should be used?

6543 commented

2020-12-07 11:43:27 +00:00

the rest is fine

khmarbaise commented

2020-12-07 11:57:06 +00:00

Check enhanced as suggested.

6543 marked this conversation as resolved