move git auth prompts to interact module #276

Merged
6543 merged 3 commits from noerw/tea:issue-231-refactor-prompt-2 into master 2020-12-08 01:21:05 +00:00
Member

closes #231

closes #231
noerw added 2 commits 2020-12-07 14:21:57 +00:00
allow up to 3 ssh key password attempts
All checks were successful
continuous-integration/drone/pr Build is passing
7cdb7823c4
noerw added the
kind
refactor
skip-changelog
status/needs-reviews
labels 2020-12-07 14:22:34 +00:00
noerw changed title from move git auth prompts to interact to move git auth prompts to interact module 2020-12-07 14:25:04 +00:00
Owner

one way to solve this for now :)

I still think we can do eaven better, but until I myselve do not have a working & nice idear a callback func is one clean way to solve it

one way to solve this for now :) I still think we can do eaven better, but until I myselve do not have a working & nice idear a callback func is one clean way to solve it
6543 approved these changes 2020-12-07 17:34:58 +00:00
Dismissed
6543 reviewed 2020-12-07 17:36:15 +00:00
Dismissed
@ -0,0 +9,4 @@
)
// PromptPassword asks for a password and blocks until input was made.
func PromptPassword(ctx string) (pass string, err error) {
Owner

one nit, dont call it ctx, name it something like "sender" or so ... since ctx is normaly used for context.Contect

one nit, dont call it ctx, name it something like "sender" or so ... since ctx is normaly used for context.Contect
noerw marked this conversation as resolved
noerw added 1 commit 2020-12-07 17:42:16 +00:00
rename param
All checks were successful
continuous-integration/drone/pr Build is passing
5c6e494ed6
6543 approved these changes 2020-12-07 17:53:50 +00:00
Dismissed
noerw added this to the v0.6.0 milestone 2020-12-07 21:15:46 +00:00
lunny approved these changes 2020-12-07 23:49:50 +00:00
Dismissed
6543 merged commit d0e05e8be2 into master 2020-12-08 01:21:05 +00:00
6543 removed the
status/needs-reviews
label 2020-12-08 03:44:36 +00:00
Sign in to join this conversation.
No description provided.